8000 Jackson => Gson by mathieucarbou · Pull Request #3177 · ehcache/ehcache3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Jackson => Gson #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

Jackson => Gson #3177

merged 1 commit into from
Jul 20, 2023

Conversation

mathieucarbou
Copy link
Member
@mathieucarbou mathieucarbou commented Jun 30, 2023 •
edited
Loading

@mathieucarbou mathieucarbou self-assigned this Jun 30, 2023
@mathieucarbou mathieucarbou marked this pull request as ready for review July 12, 2023 11:12
chrisdennis
chrisdennis requested changes Jul 12, 2023
View reviewed changes
...ent/src/test/java/org/ehcache/management/providers/settings/EhcacheSettingsProviderTest.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to preserve the existing indentation since it's not objectionably wrong.

< 8000 div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

ehcache-management/src/test/resources/settings-capability.json
@@ -1 +1,90 @@
{"name":"SettingsCapability","descriptors":[{"cacheName":"cache-1","keyType":"java.lang.String","valueType":"java.lang.String","resourcePools":{"heap":{"level":10000,"persistent":false,"type":"ENTRY","size":10,"unit":"entries"},"offheap":{"level":1000,"persistent":false,"type":"MEMORY","size":1,"unit":"MB"},"disk":{"level":100,"persistent":true,"type":"MEMORY","size":2,"unit":"MB"}}},{"cacheName":"cache-2","keyType":"java.lang.String","valueType":"java.lang.String","resourcePools":{"heap":{"level":10000,"persistent":false,"type":"ENTRY","size":10,"unit":"entries"},"offheap":{"level":1000,"persistent":false,"type":"MEMORY","size":1,"unit":"MB"},"disk":{"level":100,"persistent":true,"type":"MEMORY","size":2,"unit":"MB"}}},{"cacheManagerDescription":"","instanceId":"UUID","cacheManagerName":"my-cm-1"},"tags":["baz","boo","foo"]}],"capabilityContext":{"attributes":[{"name":"instanceId","required":true},{"name":"cacheManagerName","required":true},{"name":"cacheName","required":true}]}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Github right here... did we lose a }? Was it an error in the original file that was tolerated at parse time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so!

@mathieucarbou mathieucarbou force-pushed the json/master branch 3 times, most recently from 8412f9a to ca71ffd Compare July 18, 2023 20:27
@mathieucarbou
Copy link
Member Author

Build not passing - cannot find the releases artefacts (infra issue ?)

@chrisdennis chrisdennis merged commit 4f2a10b into ehcache:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdennis chrisdennis chrisdennis approved these changes

@GaryWKeim GaryWKeim Awaiting requested review from GaryWKeim

Assignees

@mathieucarbou mathieucarbou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieucarbou @chrisdennis
0