8000 refactor: use async function and support egg@2 by dead-horse · Pull Request #10 · eggjs/watcher · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: use async function and support egg@2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in 8000 to your account

Merged
merged 1 commit into from
Nov 10, 2017
Merged

refactor: use async function and support egg@2 #10

merged 1 commit into from
Nov 10, 2017

Conversation

dead-horse
Copy link
Member
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore mentioned this pull request Nov 10, 2017
29 tasks
@codecov-io
Copy link
codecov-io commented Nov 10, 2017

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files           8        8           
  Lines          84       84           
=======================================
  Hits           75       75           
  Misses          9        9
Impacted Files Coverage Δ
agent.js 100% <100%> (ø) ⬆️
app.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd67a9d...639ee09. Read the comment docs.

Copy link
Member
@atian25 atian25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -20,18 +20,18 @@
},
"dependencies": {
"camelcase": "^4.1.0",
"sdk-base": "^3.1.1",
"sdk-base": "^3.3.0",
"wt": "^1.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

话说 wt 里面的 sdk-base 好像还是旧的

@dead-horse dead-horse merged commit c1d8460 into master Nov 10, 2017
@dead-horse dead-horse deleted the egg2 branch November 10, 2017 12:16
@dead-horse
Copy link
Member Author

3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0