8000 refactor: upgrade koa-session, support egg2. [BREAKING CHANGE] by dead-horse · Pull Request #10 · eggjs/session · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: upgrade koa-session, support egg2. [BREAKING CHANGE] #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2017
Merged

refactor: upgrade koa-session, support egg2. [BREAKING CHANGE] #10

merged 2 commits into from
Nov 9, 2017

Conversation

dead-horse
Copy link
Member
@dead-horse dead-horse commented Nov 9, 2017 •
edited by atian25
Loading
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

drop node <8 support, so it is a breaking change.

eggjs/egg#1564

@atian25
Copy link
Member
atian25 commented Nov 9, 2017

这个库没有开 win 的测试？

@dead-horse
Copy link
Member Author

依赖了 redis-server

@codecov-io
Copy link
codecov-io commented Nov 9, 2017 •
edited
Loading

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          17     20    +3     
=====================================
+ Hits           17     20    +3
Impacted Files Coverage Δ
app/extend/application.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1eca6...5056f4c. Read the comment docs.

atian25
atian25 reviewed Nov 9, 2017
View reviewed changes
.autod.conf.js
@@ -8,7 +8,6 @@ module.exports = {
'benchmark',
],
devdep: [
'egg',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

干掉后 autod 会被干掉依赖吧？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不会，dev 不会去除，因为现在依赖的是 next tag，所以就没必要在这里写了

@dead-horse dead-horse A376 merged commit 38e901b into master Nov 9, 2017
@dead-horse dead-horse deleted the egg2 branch November 9, 2017 06:06
@popomore popomore mentioned this pull request Nov 9, 2017
Closed
29 tasks
@atian25
Copy link
Member
atian25 commented Nov 9, 2017

回头 egg guide docs 那边也要改改对应的 generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atian25 atian25 atian25 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dead-horse @atian25 @codecov-io
0