refactor: use async function and support egg@2 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 12 12
Lines 185 185
=======================================
Hits 177 177
Misses 8 8
Continue to review full report at Codecov.
|
atian25
approved these changes
Nov 10, 2017
| @@ -37,11 +37,11 @@ class DayRotator extends Rotator { | |||
| this.app.deprecate('[egg-logrotator] Do not use app.config.logger.rotateLogDirs, only rotate core loggers and custom loggers'); | |||
There was a problem hiding this comment.
先保留吧，�尽量让这个版本升级减少应用层感知到的 breaking change
There was a problem hiding this comment.
object 不能 for of，而且 node 8 这些性能问题应该也基本都没了
There was a problem hiding this comment.
那个是个 Map 来着，可以 for...of map.values()
嗯，那就这样吧
| @@ -13,8 +13,8 @@ module.exports = app => { | |||
| cron: '0 0 * * *', // run every day at 00:00 | |||
| }, | |||
|
|
|||
| * task() { | |||
| yield rotator.rotate(); | |||
| async task() { | |||
There was a problem hiding this comment.
后面非 class 形式的要废掉么？这种简单的不想用 class
There was a problem hiding this comment.
应该会一直兼容吧，现在觉得 class 方式写起来不够简洁，那个 static get schedule() {} 挺丑的。。。 ES 还不支持 static const
|
3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change