split logs before upload ensure group size < 3M and log count < 4096 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 58 85 +27
=====================================
+ Hits 58 85 +27
Continue to review full report at Codecov.
|
|
上传后切割可能太大，直接超时。而不是 PostBodyTooLarge 的错误了。 |
popomore
reviewed
Jun 11, 2019
lib/sls_logger_client.js
Outdated
| this.emit('error', error); | ||
| return [{ group: null, logCount: 1 }]; | ||
| } | ||
| const half = Math.floor(count / 2); |
There was a problem hiding this comment.
这里是不是再多判断一下，如果 half 也超过限制了？可以根据 length 和 count 算出一个比较合理的数字，不一定是一分为二。
There was a problem hiding this comment.
计算 size 和 size limit 的比例，count 和 count limit 的比例。用两者中大的数去分组。
先用 4096 分组，然后再根据日志的平均大小分组
bdc5ff3 to
3b95032
Compare
popomore
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change