refactor: use async function and support egg@2 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 53 50 -3
=====================================
- Hits 53 50 -3
Continue to review full report at Codecov.
|
|
好像这个库没有多文件上传的 fixture ? |
|
有的，multipart 默认就支持 |
|
但是之前利用了 generator 可以返回不同的内容实现的，所以可以 |
|
但这个插件本身好像没有测试多文件的 fixture，要不要加下。 |
|
有测试多 fields 的，没区别 |
atian25
approved these changes
Nov 9, 2017
app/extend/context.js
Outdated
8000
| @@ -34,9 +33,9 @@ module.exports = { | |||
| */ | |||
| getFileStream() { | |||
| @@ -19,30 +19,30 @@ module.exports = function* () { | |||
| // 例如 文件是必须字段，那么就报错 | |||
| // 这里只是给出提示 | |||
| if (!part || !part.filename) { | |||
|
fixed |
atian25
approved these changes
Nov 9, 2017
|
2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
eggjs/egg#1564
此处有要注意的地方，只能通过
await parts()而不能await parts来实现获取多个上传文件。但是在 generator function 中，仍然可以使用yield parts