8000 FND-386 - Eliminate deprecated elements that have been deprecated for more than 2 quarters by ElisaKendall · Pull Request #2071 · edmcouncil/fibo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FND-386 - Eliminate deprecated elements that have been deprecated for more than 2 quarters #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 15, 2024
Merged

FND-386 - Eliminate deprecated elements that have been deprecated for more than 2 quarters #2071

merged 13 commits into from
Nov 15, 2024

Conversation

ElisaKendall
Copy link
Contributor
@ElisaKendall ElisaKendall commented Nov 14, 2024 •
edited
Loading

Description

Eliminate long-time deprecated elements, particularly those elements deprecated due to integration of the OMG Commons Ontology Library v1.1, from the FIBO FND domain area. This update eliminates two ontologies, namely Roles and Quantities and Units, in favor of their replacements in Commons.

Fixes: #2070 / FND-386

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
FND-386 #comment - removed old deprecations from the agents ontology
c23b713 
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - removed deprecated elements from the documents ont…
a373183 
…ology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - eliminated deprecated elements in dates and times …
a35e84f 
…ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - revised the FND parties ontology to remove depreca…
9baf2bd 
…ted elements

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - eliminate any reference to the FND/Parties/Roles o…
aaeaac9 
…ntology elsewhere in FIBO, given that it only contained deprecated elements

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - remove the Roles ontology from FND now that nothin…
16cf3a3 
…g references it

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - remove the now redundant quantities and units onto…
ae69251 
…logy from FND, including the module related detail

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - eliminated deprecated elements from the relations …
b357499 
…ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - eliminated deprecated elements from the analytics …
2ef4b2a 
…ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added consistency About overall consistency FND FIBO Foundations labels Nov 14, 2024
@ElisaKendall ElisaKendall self-assigned this Nov 14, 2024
@ElisaKendall
FND-386 #comment - addressed remaining reference to a property used i…
6ed6790 
…n an example index that moved to commons

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - eliminated deprecated elements in DER, FBC, and Lo…
8aec8fc 
…ans that were deprecated over 6 months ago

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - elminated elements in SEC that have been deprecate…
b2a4e3c 
…d for more than 6 months

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-386 #comment - addressed two elements that were deprecated in sec…
3520c87 
…urities and moved to a jurisdiction specific ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title FND-386 - Eliminate deprecated elements that have been deprecated for more than 2 quarters (WIP) FND-386 - Eliminate deprecated elements that have been deprecated for more than 2 quarters Nov 15, 2024
@ElisaKendall ElisaKendall mentioned this pull request Nov 15, 2024
Closed
rivettp
rivettp approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor
@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following are flags for future review while we have the record of the replaced elements (though not their definition).

Not happy about exemplifies generally, even less it replacing realizes.

Not sure the BusinessDates holdsDuring is really the same original meaning as its replacement in Parties and Situations.

Likewise hasRecuurenceStarDate seems more specific than hasStartDate.

There are several deleted deprecated classes in SecuritiesRestrictions with no replacement equivalentClass - was that deliberate?

PartyInRole seems distinct from PartyRole

We should check why Analytics had both Ratio and RatioValue, both replaced by Ratio

@ElisaKendall
Copy link
Contributor Author

The following are flags for future review while we have the record of the replaced elements (though not their definition).

Not happy about exemplifies generally, even less it replacing realizes.
[efk} -- realizes has a different definition in Commons, so we should revisit but did not want two properties with the same name that might confuse users

Not sure the BusinessDates holdsDuring is really the same original meaning as its replacement in Parties and Situations.
[efk] Happy to discuss but I think it is.

Likewise hasRecuurenceStarDate seems more specific than hasStartDate.
[efk] Ok - we should think about this as we have use cases for it.

There are several deleted deprecated classes in SecuritiesRestrictions with no replacement equivalentClass - was that deliberate?
[efk] they were moved to a US-specific and/or EU specific jurisdiction ontology -- still there, just improved and made specific to the jurisdiction.

PartyInRole seems distinct from PartyRole
[efk] not the way we've used it to date

We should check why Analytics had both Ratio and RatioValue, both replaced by Ratio
[efk] only one was used and we reviewed that on a couple of Commons calls to make sure that it was the right approach, though you may not have been on.

@ElisaKendall ElisaKendall merged commit 1977326 into edmcouncil:master Nov 15, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the FND-386 branch November 15, 2024 06:04
@mereolog mereolog added this to the 2024Q4 FIBO Release milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rivettp rivettp rivettp approved these changes

@jfgemski jfgemski jfgemski approved these changes

@tahoeblue tahoeblue Awaiting requested review from tahoeblue

Assignees

@ElisaKendall ElisaKendall

Labels
consistency About overall consistency FND FIBO Foundations
Projects
None yet
Milestone
2024Q4 FIBO Release
Development

Successfully merging this pull request may close these issues.

FND-386 - Eliminate deprecated elements that have been deprecated for more than 2 quarters
4 participants
@ElisaKendall @rivettp @jfgemski @mereolog
0