[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc fix: remove duplicate \sQuote{warn} and re-document #20

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Doc fix: remove duplicate \sQuote{warn} and re-document #20

merged 3 commits into from
Oct 13, 2024

Conversation

cgiachalis
Copy link
Contributor

This is a documentation fix PR.

It removes the duplicate \sQuote{warn} from docs. You can inspect the change diff in the log_setup.Rd below.

@cgiachalis
Doc fix: remove duplicate \sQuote{warn} and re-document
39b7d19 
* Re-document with roxygen2::roxygenise()
eddelbuettel
eddelbuettel reviewed Oct 13, 2024
View reviewed changes
Copy link
Owner
@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pretty-please add a ChangeLog entry? Standard format of date, two spaces, name, two spaces email and then entries per file after a tab and *. I usually make them comment for the changed file and just list the two generated files.

@cgiachalis
Copy link
Contributor Author

Sure, let me do this now.

eddelbuettel
eddelbuettel approved these changes Oct 13, 2024
View reviewed changes
ChangeLog Outdated

* R/RcppExports.R: Idem

* DESCRIPTION (RoxygenNote): Idem
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baby nag: No empty lines between items that belong together, and I usually do mention DESCRIPTION for the roxygen note (it will fall back to 6.* from processing here anyway). I can deal with though.

Oh, and an eight space tab before the *. I can clean this up. Thanks for adding it!

Copy link
Contributor Author
@cgiachalis cgiachalis Oct 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No empty lines between items that belong together

Duh.. Changed it just before I push ..

@eddelbuettel eddelbuettel merged commit fe57c3f into eddelbuettel:master Oct 13, 2024
1 check passed
@cgiachalis
Copy link
Contributor Author

Oups the date is off

@eddelbuettel
Copy link
Owner

Whoops. I missed that too. Now fixed.

Hope you're enjoying RcppSpdlog. The spdl package adds some lightweight symmetric use from R too.

@cgiachalis
Copy link
Contributor Author

Hope you're enjoying RcppSpdlog. The spdl package adds some lightweight symmetric use from R too.

Yeah, I landed here straight from spdl package :)

@cgiachalis cgiachalis deleted the cg/documentation_fix branch October 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgiachalis @eddelbuettel