-
Notifications
You must be signed in to change notification settings - Fork 54
docs: correct STACKIT IDs #3545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b07db8e
to
e830027
Compare
Will wait for review / approval and then backport accordingly. |
8000
m1ghtym0
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad, I've got things mixed up while writing the warning, so people won't mix up things 🙈
Thanks for fixing!
thomasten
approved these changes
Dec 11, 2024
m1ghtym0
requested changes
Dec 11, 2024
e830027
to
b8d0daf
Compare
m1ghtym0
approved these changes
Dec 11, 2024
burgerdev
approved these changes
Dec 11, 2024
We got OpenStack and STACKIT IDs mixed up in our documentation previously. The OpenStack project ID is required in the `clouds.yaml` file, while the STACKIT project ID is required in the Constellation config. This fixes the warning for the OpenStack project ID in `clouds.yaml`, and adds an additional warning for the STACKIT project ID in the configuration section.
b8d0daf
to
bcc284b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
needs backport
This PR needs to be backported to a previous release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We got OpenStack and STACKIT IDs mixed up in our documentation previously. The OpenStack project ID is required in the
clouds.yaml
file 1, while the STACKIT project ID is required in the Constellation config 2. This fixes the warning for the OpenStack project ID inclouds.yaml
, and adds an additional warning for the STACKIT project ID in the configuration section.Proposed change(s)
Checklist
Footnotes
https://github.com/edgelesssys/wiki/blob/master/documentation/constellation/stackit.md#cloudsyaml ↩
https://github.com/edgelesssys/wiki/blob/master/documentation/constellation/stackit.md#constellation-confyaml ↩