8000 docs: correct STACKIT IDs by msanft · Pull Request #3545 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: correct STACKIT IDs #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

docs: correct STACKIT IDs #3545

merged 1 commit into from
Dec 12, 2024

Conversation

msanft
Copy link
Contributor
@msanft msanft commented Dec 11, 2024

Context

We got OpenStack and STACKIT IDs mixed up in our documentation previously. The OpenStack project ID is required in the clouds.yaml file 1, while the STACKIT project ID is required in the Constellation config 2. This fixes the warning for the OpenStack project ID in clouds.yaml, and adds an additional warning for the STACKIT project ID in the configuration section.

Proposed change(s)

  • Fix OpenStack project ID warning (said STACKIT previously).
  • Add an additional warning for the STACKIT project ID.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

Footnotes

  1. https://github.com/edgelesssys/wiki/blob/master/documentation/constellation/stackit.md#cloudsyaml

  2. https://github.com/edgelesssys/wiki/blob/master/documentation/constellation/stackit.md#constellation-confyaml

@msanft msanft added documentation Improvements or additions to documentation needs backport This PR needs to be backported to a previous release labels Dec 11, 2024
@msanft msanft requested review from burgerdev and m1ghtym0 December 11, 2024 16:14
@msanft msanft requested a review from thomasten as a code owner December 11, 2024 16:14
Copy link
netlify bot commented Dec 11, 2024

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit bcc284b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/675a9db6fb6d5f000835bdbe
😎 Deploy Preview https://deploy-preview-3545--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@msanft msanft force-pushed the msanft/docs/stackit-id branch from b07db8e to e830027 Compare December 11, 2024 16:17
@msanft
Copy link
Contributor Author
msanft commented Dec 11, 2024

Will wait for review / approval and then backport accordingly.

8000
Copy link
Member
@m1ghtym0 m1ghtym0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, I've got things mixed up while writing the warning, so people won't mix up things 🙈
Thanks for fixing!

@msanft msanft force-pushed the msanft/docs/stackit-id branch from e830027 to b8d0daf Compare December 11, 2024 16:59
@msanft msanft requested a review from m1ghtym0 December 11, 2024 16:59
We got OpenStack and STACKIT IDs mixed up in our documentation previously. The OpenStack project ID is required in the `clouds.yaml` file, while the STACKIT project ID is required in the Constellation config. This fixes the warning for the OpenStack project ID in `clouds.yaml`, and adds an additional warning for the STACKIT project ID in the configuration section.
@msanft msanft force-pushed the msanft/docs/stackit-id branch from b8d0daf to bcc284b Compare December 12, 2024 08:24
@msanft msanft merged commit 1495a7f into main Dec 12, 2024
8 checks passed
@msanft msanft deleted the msanft/docs/stackit-id branch December 12, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs backport This PR needs to be backported to a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0