8000 Make Kubernetes serviceCIDR configurable in config by 3u13r · Pull Request #2660 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make Kubernetes serviceCIDR configurable in config #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2023
Merged

Make Kubernetes serviceCIDR configurable in config #2660

merged 2 commits into from
Dec 1, 2023

Conversation

3u13r
Copy link
Contributor
@3u13r 3u13r commented Nov 29, 2023 •
edited
Loading

Context

Kubernetes uses this serviceCIDR to allocate ClusterIPs from it: https://kubernetes.io/docs/concepts/services-networking/service/#type-clusterip
For peered networks it is essential to be able to re-configure all CIDRs as to not conflict with existing allocations in the peered network.

Proposed change(s)

  • Add optional serviceCIDR field in constellation-conf.yaml
  • Pass value through our Terraform files

Additional info

Terraform test: https://github.com/edgelesssys/constellation/actions/runs/7059236028
E2E test: https://github.com/edgelesssys/constellation/actions/runs/7059241745

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@3u13r 3u13r added the feature This introduces new functionality label Nov 29, 2023
@3u13r 3u13r added this to the v2.14.0 milestone Nov 29, 2023
@3u13r 3u13r requested a review from derpsteb as a code owner November 29, 2023 14:55
@netlify Netlify
Copy link
netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 75d06a6
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6569bec887f40500089bad79

derpsteb
derpsteb reviewed Nov 30, 2023
View reviewed changes
derpsteb
derpsteb reviewed Nov 30, 2023
View reviewed changes
@derpsteb
Copy link
Contributor

Maybe add a sentence of context what the serviceCIDR is / how kubeadm uses it? Because this will be part of the changelog.

@3u13r
Copy link
Contributor Author
3u13r commented Nov 30, 2023

Maybe add a sentence of context what the serviceCIDR is / how kubeadm uses it? Because this will be part of the changelog.

Yes, I think we can simply reference the official K8s docs.

@3u13r 3u13r force-pushed the feat/config/service-cidr branch from a3d37cb to 75d06a6 Compare December 1, 2023 11:08
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 1, 2023

Coverage report

Package Old New Trend
bootstrapper/cmd/bootstrapper [no test files] [no test files] 🚧
bootstrapper/initproto [no test files] [no test files] 🚧
bootstrapper/internal/initserver 73.70% 73.70% ↔️
bootstrapper/internal/kubernetes 74.60% 74.80% ↗️
bootstrapper/internal/kubernetes/k8sapi 13.60% 13.40% ↘️
cli/internal/cmd 58.20% 58.20% ↔️
internal/config 79.20% 79.30% ↗️

@3u13r 3u13r merged commit 63cdd03 into main Dec 1, 2023
@3u13r 3u13r deleted the feat/config/service-cidr branch December 1, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derpsteb derpsteb derpsteb approved these changes

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@3u13r @derpsteb
0