8000 terraform: Azure Marketplace image support by msanft · Pull Request #2651 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

terraform: Azure Marketplace image support #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Dec 8, 2023
Merged

terraform: Azure Marketplace image support #2651

merged 34 commits into from
Dec 8, 2023

Conversation

msanft
Copy link
Contributor
@msanft msanft commented Nov 27, 2023 •
edited by elchead
Loading

Context

We want to let users choose to use the VM image we distribute on the Azure marketplace.

Proposed change(s)

  • Allow users to set a config variable to use the marketplace image on Azure.

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Nov 27, 2023
@msanft msanft added this to the v2.14.0 milestone Nov 27, 2023
@msanft msanft requested review from m1ghtym0 and thomasten November 27, 2023 16:56
@netlify Netlify
Copy link
netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit f0ce0a8
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6572faeebd7f0a00085cd6fc

@m1ghtym0
Copy link
Member
8000

Docs come in a separate PR?

@msanft
Copy link
Contributor Author
msanft commented Nov 28, 2023

Docs come in a separate PR?

Sorry, actually just forgot to push some pending commits.

@msanft msanft requested a review from m1ghtym0 November 28, 2023 07:24
@msanft msanft force-pushed the feat/terraform/azure-marketplace-support branch from 78647d2 to b64ee05 Compare November 28, 2023 13:04
@msanft msanft requested review from daniel-weisse and removed request for derpsteb November 28, 2023 13:42
daniel-weisse
daniel-weisse approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member
@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this, but code changes lgtm

@msanft msanft requested a review from 3u13r as a code owner November 28, 2023 17:23
daniel-weisse
daniel-weisse reviewed Nov 29, 2023
View reviewed changes
3u13r
3u13r suggested changes Nov 29, 2023
View reviewed changes
@msanft
Copy link
Contributor Author
msanft commented Nov 30, 2023

v2.14.0 debug image
v2.15.0 debug image

Upgrade TODO

malt3
malt3 reviewed Nov 30, 2023
View reviewed changes
@msanft msanft requested a review from 3u13r November 30, 2023 11:27
3u13r
3u13r approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor
@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise LGTM

thomasten
thomasten reviewed Dec 3, 2023
View reviewed changes
dev-docs/workflows/marketplace-images.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add this to the user docs and add a "contact us" banner (similar to what we do in the marblerun docs). I don't have a strong opinion. What do you think @m1ghtym0?

@msanft msanft force-pushed the feat/terraform/azure-marketplace-support branch from 2dfc863 to 9869faa Compare December 4, 2023 12:46
@msanft msanft requested a review from elchead as a code owner December 6, 2023 07:53
@msanft msanft requested a review from thomasten December 6, 2023 07:55
@msanft msanft force-pushed the feat/terraform/azure-marketplace-support branch from c4e53c4 to b2707e6 Compare December 6, 2023 07:59
@elchead
Copy link
Contributor
elchead commented Dec 7, 2023

Why isn't this included in the changelog?

elchead
elchead requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor
@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only looked at the TF related changes

msanft and others added 26 commits December 8, 2023 12:15
@msanft
config: remove dive key
a2fa034
@msanft
dev-docs: add instructions on how to use marketplace images
dca944c
@msanft
terraform: fix unit test
572d1dd
@msanft
terraform: only fetch image for non-marketplace images
3c48fa9
@msanft
mpimage: refactor image selection
54b17ea 
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft
[remove] increase minor version for image build
0e7ac90 
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft
terraform: ignore changes to source_image_reference on upgrade
39e90eb
@msanft
operator: add support for parsing Azure marketplace images
2881aa2 
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft
upgrade: fix imagefetcher call
8ff7c3f
@m1ghtym0 @msanft
docs: add info about azure marketplace
564e7a1
@msanft
image: ensure more than 1GiB in size
6D40
e1f23fb
@msanft
image: test to pad to 2GiB
ce72d25
@msanft
version: change back to v2.14.0-pre
748db29
@msanft
image: GPT-conformant image size padding
3a9d2e9
@msanft
[remove] increase version
1edf16b
@msanft
mpimage: inline prefix func
fa4d57e 
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft
ci: add marketplace image e2e test
3ba5396 
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft
[remove] register workflow
f9cb9ae
@msanft
ci: fix workflow name
42d5b1e
@msanft
ci: only allow azure test
98b1f3d
@msanft
cli: add marketplace image input to interface
e48dab5
@msanft
cli: fix argument passing
d18c459
@msanft
version: roll back to v2.14.0
e91b67b
@msanft
ci: add force-flag support
b9fe369
@thomasten @msanft
Update docs/docs/overview/license.md
5d2ad8c
@msanft @m1ghtym0
Update dev-docs/workflows/marketplace-images.md
f0ce0a8 
Co-authored-by: Moritz Eckert <m1gh7ym0@gmail.com>
@msanft msanft force-pushed the feat/terraform/azure-marketplace-support branch from 4e41dce to f0ce0a8 Compare December 8, 2023 11:15
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 8, 2023

Coverage report

Package Old New Trend
cli/internal/cloudcmd 65.30% 63.90% ↘️
cli/internal/cmd 58.50% 58.50% ↔️
cli/internal/terraform 72.30% 72.30% ↔️
e2e/internal/upgrade [no test files] [no test files] 🚧
hack/image-fetch 0.00% 0.00% 🚧
image/upload [no test files] [no test files] 🚧
internal/config 79.30% 79.30% ↔️
internal/constants [no test files] [no test files] 🚧
internal/imagefetcher 84.40% 78.80% ↘️
internal/mpimage 0.00% 95.00% 🆕
internal/osimage/azure [no test files] [no test files] 🚧
terraform-provider-constellation/internal/provider 13.10% 13.10% 🚧

@msanft msanft merged commit c15e4ef into main Dec 8, 2023
@msanft msanft deleted the feat/terraform/azure-marketplace-support branch December 8, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@malt3 malt3 malt3 approved these changes

@m1ghtym0 m1ghtym0 m1ghtym0 approved these changes

@3u13r 3u13r 3u13r approved these changes

@elchead elchead elchead approved these changes

@thomasten thomasten thomasten approved these changes

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@msanft @m1ghtym0 @elchead @malt3 @3u13r @thomasten @daniel-weisse
0