api: respect HTTP(S)_PROXY environment variable
#2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
✅ Deploy Preview for constellation-docs canceled.
|
Coverage report
|
daniel-weisse
approved these changes
Nov 23, 2023
derpsteb
approved these changes
Nov 23, 2023
elchead
pushed a commit
that referenced
this pull request
Nov 24, 2023
elchead
pushed a commit
that referenced
this pull request
Nov 24, 2023
elchead
pushed a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We create a custom
*http.Transport, which, per default, uses anilproxy (i.e. no proxy). In contrast to thehttp.DefaultClient, which uses thehttp.ProxyFromEnvironmentproxy. Therefore, it does not respect theHTTP_PROXYandHTTPS_PROXYenvironment variables, as seen in #2634.Proposed change(s)
http.ProxyFromEnvironment.Additional Information
The fix can be verified by setting
HTTPS_PROXY=http://8.8.8.8or something else which does not proxy. Then, navigate to a directory with a Constellation workspace, and executingbazel run //hack/image-fetch. Prior to this change, this would run normally as the traffic is not routed through the proxy. With the change, it will timeout as8.8.8.8does not proxy.Checklist