8000 cli: fix panic in status cmd without conf file by elchead · Pull Request #2625 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cli: fix panic in status cmd without conf file #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

elchead
Copy link
Contributor
@elchead elchead commented Nov 21, 2023

Context

When executing constellation status without a present config file, the command panics because the config reading error is not caught.
This issue occurs on 2.13 and also 2.12.

Proposed change(s)

  • return config read error

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

Copy link
netlify bot commented Nov 21, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 9812b2e
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/655cba588a762900088b7be2

@elchead elchead added the no changelog Change won't be listed in release changelog label Nov 21, 2023
@elchead elchead added this to the v2.14.0 milestone Nov 21, 2023
@elchead elchead added bug fix Fixing a bug and removed no changelog Change won't be listed in release changelog labels Nov 21, 2023
@elchead
Copy link
Contributor Author
elchead commented Nov 21, 2023

I think a bug fix release is not necessary. We should create a bug issue though.

@elchead elchead requested a review from derpsteb as a code owner November 21, 2023 14:10
@elchead elchead removed the request for review from derpsteb November 21, 2023 14:16
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 54.60% 54.60% ↔️
internal/config 80.20% 80.20% ↔️

@elchead elchead merged commit 9af514d into main Nov 22, 2023
@elchead elchead deleted the fix/cli/status-cmd branch November 22, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0