8000 attestation: print ordered measurement verification warnings and errors by daniel-weisse · Pull Request #2237 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

attestation: print ordered measurement verification warnings and errors #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

daniel-weisse
Copy link
Member

Context

Warnings and errors of measurement verification during an attestation are currently printed unordered.
Additionally, on error, only the first mismatching measurement is reported.

Proposed change(s)

  • Return warnings and errors in order of their indices
  • Print all warnings before returning on error
  • Return all mismatching measurements on error

@daniel-weisse daniel-weisse requested a review from malt3 August 15, 2023 14:15
@netlify

This comment was marked as spam.

Copy link
Contributor
@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@daniel-weisse daniel-weisse added the feature This introduces new functionality label Aug 16, 2023
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the feat/attestation/order-errors branch from c850d22 to ac382d4 Compare August 16, 2023 07:31
@daniel-weisse daniel-weisse merged commit 103817a into main Aug 16, 2023
@daniel-weisse daniel-weisse deleted the feat/attestation/order-errors branch August 16, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This introduces new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0