8000 cli: wait for public ip update before reading fqdn by derpsteb · Pull Request #2135 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cli: wait for public ip update before reading fqdn #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2023
Merged

cli: wait for public ip update before reading fqdn #2135

merged 2 commits into from
Jul 26, 2023

Conversation

derpsteb
Copy link
Contributor
@derpsteb derpsteb commented Jul 25, 2023 •
edited
Loading

Context

During our weekly tests we encounted an error while upgrading on Azure: azurerm_public_ip.loadbalancer_ip.fqdn is null. The docs explain that the value only becomes available if domain_name_label is set. Since that label is only set while migrating from 2.9 we need to wait for the property being applied during upgrades.

Proposed change(s)

  • Add data resource to azure terraform to depend on managed resource

Related issue

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@derpsteb derpsteb added the no changelog Change won't be listed in release changelog label Jul 25, 2023
@derpsteb derpsteb added this to the v2.10.0 milestone Jul 25, 2023
@derpsteb derpsteb requested review from malt3 and 3u13r July 25, 2023 14:07
@derpsteb derpsteb requested a review from katexochen as a code owner July 25, 2023 14:07
@netlify
Copy link
netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 3cdb348
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64bfe0e4dc298b0008a49f30

@derpsteb derpsteb merged commit 7db058f into main Jul 26, 2023
@derpsteb derpsteb deleted the fix/cli/terraform-azure branch July 26, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elchead elchead elchead approved these changes

@malt3 malt3 Awaiting requested review from malt3

@3u13r 3u13r Awaiting requested review from 3u13r

@katexochen katexochen Awaiting requested review from katexochen

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@derpsteb @elchead
0