8000 cli: output CSI driver versions on `status` by daniel-weisse · Pull Request #2128 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cli: output CSI driver versions on status #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2023
Merged

cli: output CSI driver versions on status #2128

merged 4 commits into from
Jul 27, 2023

Conversation

daniel-weisse
Copy link
Member

Context

Individual versions of the CSI chart were not printed when running constellation status

Proposed change(s)

  • Print the installed versions of the CSI chart
  • Only print aws-load-balancer-controller version if it is installed

@daniel-weisse daniel-weisse added this to the v2.10.0 milestone Jul 24, 2023
@daniel-weisse daniel-weisse requested a review from derpsteb as a code owner July 24, 2023 12:00
@netlify
Copy link
netlify bot commented Jul 24, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit c9106c0
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64c26fdb37a7fd00070f81b7

3u13r
3u13r reviewed Jul 24, 2023
View reviewed changes
@daniel-weisse daniel-weisse force-pushed the feat/cli/status-csi-drivers branch from b0ef84e to aeb20b6 Compare July 24, 2023 12:58
elchead
elchead approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor
@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@daniel-weisse daniel-weisse force-pushed the feat/cli/status-csi-drivers branch from e33db13 to 41c2388 Compare July 27, 2023 09:11
@daniel-weisse
Output CSI driver versions
0451265 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Improve status output
7b93236 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Correctly update CSI version
298fb32 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Fix status unit test
c9106c0 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the feat/cli/status-csi-drivers branch from 089c831 to c9106c0 Compare July 27, 2023 13:23
@daniel-weisse daniel-weisse added the feature 8A48 This introduces new functionality label Jul 27, 2023
@daniel-weisse daniel-weisse merged commit 9bc8217 into main Jul 27, 2023
@daniel-weisse daniel-weisse deleted the feat/cli/status-csi-drivers branch July 27, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3u13r 3u13r 3u13r left review comments

@elchead elchead elchead approved these changes

@derpsteb derpsteb Awaiting requested review from derpsteb

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-weisse @3u13r @elchead
0