bootstrapper: add fallback endpoint and custom endpoint to apiserver certificate SAN field #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
derpsteb
reviewed
Jul 17, 2023
derpsteb
reviewed
Jul 17, 2023
derpsteb
reviewed
Jul 17, 2023
derpsteb
approved these changes
Jul 17, 2023
daniel-weisse
approved these changes
Jul 19, 2023
3u13r
suggested changes
Jul 19, 2023
| return fmt.Errorf("setting new kubeadm config: %w", err) | ||
| } | ||
|
|
||
| fmt.Fprintln(u.outWriter, "Successfully extended the cluster's apiserver SAN field") |
There was a problem hiding this comment.
This returns an unchecked error. This happens throughout this file. I think we should either handle this with "normal" error handling or have something like mustFprintln(...) or must(fmt.Fprintln(...)) so that we don't forget about the error.
Of course this can be handled in another PR.
There was a problem hiding this comment.
I'll do a follow up PR
3u13r
suggested changes
Jul 20, 2023
3u13r
suggested changes
Jul 21, 2023
8e4505c to
dbf95ab
Compare
constants: add new constants for cluster configuration and custom endpoint cloud: support apiserver cert sans and prepare for endpoint migration on AWS config: add customEndpoint field bootstrapper: use per-CSP apiserver cert SANs cli: route customEndpoint to terraform and add migration for apiserver cert SANs bootstrapper: change interface of GetLoadBalancerEndpoint to return host and port separately
dbf95ab to
cae6420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is part of the canonical endpoint RFC. We start adding the fallback endpoint and the custom endpoint to the apiserver certificate SAN field.
After this is rolled out, we can use the new endpoints.
Proposed change(s)
Checklist