8000 cli: new flag to set the attestation type for `config generate` by elchead · Pull Request #1769 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cli: new flag to set the attestation type for config generate #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 17, 2023
Merged

cli: new flag to set the attestation type for config generate #1769

merged 18 commits into from
May 17, 2023

Conversation

elchead
Copy link
Contributor
@elchead elchead commented May 15, 2023 •
edited
Loading

Proposed change(s)

  • new --attestation flag for constellation config generate to specify which type to use for the given cloud provider

AB2976

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@CLAassistant
Copy link
CLAassistant commented May 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
netlify bot commented May 15, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit a6c71bc
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6464b14cf32dce0007601ebf

@elchead elchead marked this pull request as draft May 15, 2023 12:52
@elchead elchead marked this pull request as ready for review May 15, 2023 13:31
@elchead elchead marked this pull request as draft May 15, 2023 13:50
@elchead elchead force-pushed the feat/attestation/config branch from ad1f757 to ffe6126 Compare May 15, 2023 14:05
@elchead elchead marked this pull request as ready for review May 15, 2023 14:10
@elchead elchead added the feature This introduces new functionality label May 15, 2023
katexochen
katexochen reviewed May 15, 2023
View reviewed changes
Copy link
Member
@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick thoughts on Go style, looks quite good. 👍

derpsteb
derpsteb reviewed May 15, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 15, 2023
View reviewed changes
@elchead elchead requested a review from thomasten as a code owner May 16, 2023 06:56
@elchead elchead requested review from derpsteb and katexochen May 16, 2023 07:02
@elchead elchead changed the title Add attestation flag to specify type in config config: add CLI flag to configure the attestation type May 16, 2023
@elchead elchead changed the title config: add CLI flag to configure the attestation type cli: add flag to configure the attestation type May 16, 2023
@elchead elchead changed the title cli: add flag to configure the attestation type cli: add flag to set the attestation type for config generate May 16, 2023
@elchead elchead changed the title cli: add flag to set the attestation type for config generate cli: new flag to set the attestation type for config generate May 16, 2023
@elchead elchead force-pushed the feat/attestation/config branch from 5dd28ec to 5d09b1f Compare May 16, 2023 07:14
@elchead
Copy link
Contributor Author
elchead commented May 16, 2023

I added some short comments for Mac and PR in the build.md

@elchead elchead force-pushed the feat/attestation/config branch from a05e293 to c90d868 Compare May 16, 2023 09:22
@elchead elchead force-pushed the feat/attestation/config branch from c90d868 to 8b41e68 Compare May 16, 2023 09:26
daniel-weisse
daniel-weisse reviewed May 16, 2023
View reviewed changes
daniel-weisse
daniel-weisse reviewed May 16, 2023
View reviewed changes
Copy link
Member
@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont have a strong opinion on how/if we should rename the variant package.
Feel free to discuss with @katexochen

@elchead elchead requested a review from 3u13r as a code owner May 16, 2023 13:20
@3u13r 3u13r removed their request for review May 16, 2023 16:19
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
derpsteb
derpsteb reviewed May 17, 2023
View reviewed changes
@derpsteb
Copy link
Contributor

Some last minor comments. Good to merge after that that 👍

@katexochen katexochen removed their request for review May 17, 2023 10:44
derpsteb
derpsteb approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor
@derpsteb derpsteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@elchead elchead merged commit f99e06b into main May 17, 2023
@elchead elchead deleted the feat/attestation/config branch May 17, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen left review comments

@daniel-weisse daniel-weisse daniel-weisse left review comments

@derpsteb derpsteb derpsteb approved these changes

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elchead @CLAassistant @derpsteb @katexochen @daniel-weisse
0