8000 docs: fix terminate docs filename by msanft · Pull Request #1212 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix terminate docs filename #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2023
Merged

docs: fix terminate docs filename #1212

merged 1 commit into from
Feb 19, 2023

Conversation

msanft
Copy link
Contributor
@msanft msanft commented Feb 17, 2023 •
edited
Loading

Proposed change(s)

  • Change the required files for cluster termination from terraform.tfstate to the Terraform state directory defined in constants.go

Related issue

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@msanft msanft requested a review from thomasten as a code owner February 17, 2023 09:11
@msanft msanft added this to the v2.6.0 milestone Feb 17, 2023
@msanft msanft added the no changelog Change won't be listed in release changelog label Feb 17, 2023
@msanft msanft self-assigned this Feb 17, 2023
@msanft msanft requested a review from datosh February 17, 2023 09:12
@netlify
Copy link
netlify bot commented Feb 17, 2023

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 9947a84
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63ef44db9f65b50008c85e0b
😎 Deploy Preview https://deploy-preview-1212--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@msanft msanft mentioned this pull request Feb 17, 2023
Merged
3 tasks
@msanft msanft added the documentation Improvements or additions to documentation label Feb 17, 2023
@msanft msanft changed the title fix terminate docs filename docs: fix terminate docs filename Feb 17, 2023
datosh
datosh reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor
@datosh datosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon the change is correct.

I was mostly confused about why we explicitly mention this here. All CLI commands need to be executed in the Constellation workspace. Maybe this is better to be merged with the Terraform documentation we have? We can mention that Constellation CLI can be used to terminate from workdir, but in order to execute Terraform one needs to cd into one of the two Terraform workspaces..?

Maybe @3u13r can provide some insight.

@msanft
Copy link
Contributor Author
msanft commented Feb 17, 2023

I reckon the change is correct.

I was mostly confused about why we explicitly mention this here. All CLI commands need to be executed in the Constellation workspace. Maybe this is better to be merged with the Terraform documentation we have? We can mention that Constellation CLI can be used to terminate from workdir, but in order to execute Terraform one needs to cd into one of the two Terraform workspaces..?

Maybe @3u13r can provide some insight.

Agreed. I think this is rather a question on which (maybe obvious) details we explain how granular. I will bring this up in the stand-up

@thomasten
Copy link
Member

merging this as it is already an improvement

@thomasten thomasten merged commit 013be33 into main Feb 19, 2023
@thomasten thomasten deleted the fix/terminateDocs branch February 19, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datosh datosh datosh left review comments

@thomasten thomasten thomasten approved these changes

Assignees

@msanft msanft

Labels
documentation Improvements or additions to documentation no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msanft @thomasten @datosh
0