8000 init: create kubeconfig file with unique user/cluster name by daniel-weisse · Pull Request #1133 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

init: create kubeconfig file with unique user/cluster name #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 10, 2023
Merged

init: create kubeconfig file with unique user/cluster name #1133

merged 8 commits into from
Feb 10, 2023

Conversation

daniel-weisse
Copy link
Member
@daniel-weisse daniel-weisse commented Feb 1, 2023 •
edited
Loading

Proposed change(s)

  • Move --name flag from constellation create to constellation config generate/constellation iam create
    • The value is now set in the config file if one wants to customize it at a later point
  • Use the name flag together with the Cluster UID to create unique cluster and user name in the kubeconfig file generated by constellation init
    • This avoids issues when running multiple clusters and merging kubeconfig files

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@daniel-weisse daniel-weisse added the feature This introduces new functionality label Feb 1, 2023
@daniel-weisse daniel-weisse added this to the v2.6.0 milestone Feb 1, 2023
@netlify
Copy link
netlify bot commented Feb 1, 2023 •
edited
Loading

❌ Deploy Preview for constellation-docs failed.

Name Link
🔨 Latest commit 785cabf
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63e61efa21396300073d9aa7

3u13r
3u13r previously requested changes Feb 2, 2023
View reviewed changes
@katexochen katexochen removed their request for review February 2, 2023 11:37
@daniel-weisse daniel-weisse force-pushed the feat/cli/kubeconfig-naming branch from 3434073 to 8c9a175 Compare February 2, 2023 13:49
datosh
datosh approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor
@datosh datosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nit, otherwise LGTM!

@datosh
Copy link
Contributor
datosh commented Feb 2, 2023 •
edited
Loading

I just noticed we have the --name parameter in the animation of our repository README.md.

Any idea how that svg was created, or how it can be modified?

3u13r
3u13r reviewed Feb 2, 2023
View reviewed changes
@daniel-weisse daniel-weisse changed the title init: create kubeconfig flag with unique user/cluster name init: create kubeconfig file with unique user/cluster name Feb 2, 2023
@daniel-weisse daniel-weisse requested a review from malt3 February 3, 2023 13:25
@daniel-weisse
Generate kubeconfig with unique name
43b0ef5 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Move create name flag to config
93a737b 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Add name validation to config
37ff936 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Adjust name flag in e2e tests
5744452 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Fix unit test
af8215e 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Remove name flag
a6ceac5 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Adjust doc comment
388cf40 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Update ascii cinema flow
785cabf 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the feat/cli/kubeconfig-naming branch from fbdc73b to 785cabf Compare February 10, 2023 10:39
@daniel-weisse daniel-weisse requested review from 3u13r and removed request for 3u13r February 10, 2023 11:02
@daniel-weisse daniel-weisse merged commit c29107f into main Feb 10, 2023
@daniel-weisse daniel-weisse deleted the feat/cli/kubeconfig-naming branch February 10, 2023 12:27
msanft pushed a commit that referenced this pull request Feb 13, 2023
@daniel-weisse @msanft
init: create kubeconfig file with unique user/cluster name (#1133)
ed6a44f 
* Generate kubeconfig with unique name

* Move create name flag to config

* Add name validation to config

* Move name flag in e2e tests to config generation

* Remove name flag from create

* Update ascii cinema flow

---------

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
msanft pushed a commit that referenced this pull request Feb 13, 2023
@daniel-weisse @msanft
init: create kubeconfig file with unique user/cluster name (#1133)
bf6d599 
* Generate kubeconfig with unique name

* Move create name flag to config

* Add name validation to config

* Move name flag in e2e tests to config generation

* Remove name flag from create

* Update ascii cinema flow

---------

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@datosh datosh datosh approved these changes

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

@3u13r 3u13r Awaiting requested review from 3u13r

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-weisse @datosh @malt3 @3u13r
0