8000 upgrade: fix broken reference from constellation-os to constellation-version by datosh · Pull Request #939 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

upgrade: fix broken reference from constellation-os to constellation-version #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2023
Merged

upgrade: fix broken reference from constellation-os to constellation-version #939

merged 3 commits into from
Jan 11, 2023

Conversation

datosh
Copy link
Contributor
@datosh datosh commented Jan 11, 2023

Signed-off-by: Fabian Kammel fk@edgeless.systems

Proposed change(s)

  • update nodeversion references

Should we also update constellation-os-azure|gcp? @malt3

  • /operators/constellation-node-operator/config/samples/update_v1alpha1_nodeversion.yaml
  • /operators/constellation-node-operator/config/samples/update_v1alpha1_scalinggroup.yaml

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

update constellation-os to constellation-version references
eb0d10f 
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
@datosh datosh added the bug fix Fixing a bug label Jan 11, 2023
@datosh datosh requested a review from 3u13r January 11, 2023 13:22
@netlify
Copy link
netlify bot commented Jan 11, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 6bd971e
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63bebc67ee05f40008120029

@malt3
Copy link
Contributor
malt3 commented Jan 11, 2023

Should we also update constellation-os-azure|gcp

Sounds reasonable 👍

@malt3 8000
Copy link
Contributor
malt3 commented Jan 11, 2023

The CRD was renamed from nodeimage to nodeversion so I also changed that.

@datosh
Copy link
Contributor Author
datosh commented Jan 11, 2023

The CRD was renamed from nodeimage to nodeversion so I also changed that.

Thanks, good catch!

@malt3 malt3 force-pushed the fix/nodeversions-resource-name branch from b4b7ca5 to 6bd971e Compare January 11, 2023 13:40
3u13r
3u13r approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor
@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3u13r 3u13r removed the request for review from katexochen January 11, 2023 14:34
@datosh datosh merged commit 82a0fcb into main Jan 11, 2023
@datosh datosh deleted the fix/nodeversions-resource-name branch January 11, 2023 15:07
malt3 added a commit that referenced this pull request Jan 12, 2023
@malt3
upgrade: fix broken reference from constellation-os to constellation-…
e97b745 
…version (#939)

* update constellation-os to constellation-version references
* update nodeimage to nodeversion in CRD type name
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
Co-authored-by: Malte Poll <mp@edgeless.systems>
(cherry picked from commit 82a0fcb)
malt3 added a commit that referenced this pull request Jan 12, 2023
@malt3
upgrade: fix broken reference from constellation-os to constellation-…
ff85a00 
…version (#939)

* update constellation-os to constellation-version references
* update nodeimage to nodeversion in CRD type name
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
Co-authored-by: Malte Poll <mp@edgeless.systems>
(cherry picked from commit 82a0fcb)
malt3 added a commit that referenced this pull request Jan 12, 2023
@malt3
upgrade: fix broken reference from constellation-os to constellation-…
0248c8c 
…version (#939)

* update constellation-os to constellation-version references
* update nodeimage to nodeversion in CRD type name
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
Co-authored-by: Malte Poll <mp@edgeless.systems>
(cherry picked from commit 82a0fcb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@3u13r 3u13r 3u13r approved these changes

Assignees
No one assigned
Labels
bug fix Fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datosh @malt3 @3u13r
0