8000 cli: create local backups before microservice upgrades by derpsteb · Pull Request #847 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cli: create local backups before microservice upgrades #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

cli: create local backups before microservice upgrades #847

merged 1 commit into from
Jan 5, 2023

Conversation

derpsteb
Copy link
Contributor
@derpsteb derpsteb commented Jan 2, 2023

Proposed change(s)

  • Backup all CRDs and CRs before executing a helm-upgrade.

Related issue

Additional info

  • These backups can be used if an unintended/broken change to the CRDs was made. For all standard resources a helm-rollback can fix the problem. However, when changing CRDs, all resources of that type are implicitly deleted. They can not be recovered with helm-rollback.
  • GCP 1+2, sonobuoy quick
  • AWS, 1+2, sonobuoy quick

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@derpsteb derpsteb added this to the v2.4.0 milestone Jan 2, 2023
@derpsteb derpsteb requested a review from daniel-weisse January 2, 2023 16:16
@edgelesssys edgelesssys deleted a comment from netlify bot Jan 3, 2023
daniel-weisse
daniel-weisse requested changes Jan 5, 2023
View reviewed changes
@derpsteb derpsteb changed the title Create backups before helm-upgrade cli: create local backups before helm-upgrade Jan 5, 2023
@derpsteb derpsteb requested a review from daniel-weisse January 5, 2023 13:46
daniel-weisse
daniel-weisse approved these changes Jan 5, 2023
View reviewed changes
@derpsteb derpsteb force-pushed the feat/helm-crd-backups branch 2 times, most recently from cb2b81c to 71ec7a7 Compare January 5, 2023 15:28
@derpsteb
cli: create backups for CRDs and their resources
fd3023c 
These backups could be used in case an upgrade
misbehaves after helm declared it as successful.
The manual backups are required as helm-rollback
won't touch custom resources and changes to CRDs
delete resources of the old version.
@derpsteb derpsteb force-pushed the feat/helm-crd-backups branch from 71ec7a7 to fd3023c Compare January 5, 2023 15:41
@derpsteb derpsteb merged commit e7c7e35 into main Jan 5, 2023
@derpsteb derpsteb deleted the feat/helm-crd-backups branch January 5, 2023 15:52
@derpsteb derpsteb changed the title cli: create local backups before helm-upgrade cli: create local backups before microservice upgrades Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@derpsteb @daniel-weisse
0