8000 AB#2685 Add documentation for automatic IAM creation by msanft · Pull Request #711 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AB#2685 Add documentation for automatic IAM creation #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Dec 12, 2022
Merged

AB#2685 Add documentation for automatic IAM creation #711

merged 22 commits into from
Dec 12, 2022

Conversation

msanft
Copy link
Contributor
@msanft msanft commented Dec 5, 2022

Proposed change(s)

  • Add the docs for constellation iam create <provider>
  • Remove the current bash scripts for automatic IAM setup using the specific provider CLI as creation via the script should be preferred.

Checklist

@netlify
Copy link
netlify bot commented Dec 5, 2022 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 903fbb5
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63971ec86170640008a02ba2
😎 Deploy Preview https://deploy-preview-711--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@msanft

This comment was marked as resolved.

Sign in to view
@msanft msanft force-pushed the feat/IAMCreationDocs branch from 191f944 to 787f3a1 Compare December 5, 2022 09:43
@msanft msanft marked this pull request as ready for review December 5, 2022 10:28
@msanft msanft force-pushed the feat/IAMCreationDocs branch from b20fdfd to 6fbfc0d Compare December 5, 2022 10:41
@msanft msanft changed the title AB#2658 Add documentation for automatic IAM creation AB#2685 Add documentation for automatic IAM creation Dec 5, 2022
@msanft msanft force-pushed the feat/IAMCreationDocs branch from 6fbfc0d to 123b9a4 Compare December 5, 2022 10:48
datosh
datosh reviewed Dec 5, 2022
View reviewed changes
@m1ghtym0 m1ghtym0 mentioned this pull request Dec 5, 2022
Closed
2 tasks
thomasten
thomasten requested changes Dec 6, 2022
View reviewed changes
@msanft
Copy link
Contributor Author
msanft commented Dec 8, 2022

Not yet 100% happy with the current structure & phrasing, but couldn't really find out what bothers me. @thomasten @datosh can you read through it from a users perspective and let me know what you think?

@msanft msanft requested review from thomasten and datosh December 8, 2022 09:02
@datosh datosh mentioned this pull request Dec 8, 2022
Closed
datosh
datosh reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor
@datosh datosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the proposed structure!

I think we need to be deliberate in finding good section titles to guide the user on their journey.

@msanft msanft requested a review from datosh December 8, 2022 11:22
@katexochen katexochen added this to the v2.3.0 milestone Dec 9, 2022
thomasten
thomasten requested changes Dec 9, 2022
View reviewed changes
Copy link
Member
@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I like the restructuring!

msanft and others added 2 commits December 12, 2022 08:46
@msanft @thomasten
AB#2685 More precise guidance to IAM workflow
0ece5d3 
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
@msanft
AB#2685 remove info-box command explanation
494e104
@msanft msanft requested a review from thomasten December 12, 2022 11:01
thomasten
thomasten reviewed Dec 12, 2022
View reviewed changes
Copy link
Member
@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there ;)

Also take a look at the 3 hidden comments from my previous review again.

@msanft msanft requested a review from thomasten December 12, 2022 12:14
thomasten
thomasten approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member
@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about having the region notices on both pages. But I leave it up to you.

@msanft
Copy link
Contributor Author
msanft commented Dec 12, 2022

I was thinking about having the region notices on both pages. But I leave it up to you.

Makes sense!

@msanft msanft force-pushed the feat/IAMCreationDocs branch from c80d9a3 to 551339e Compare December 12, 2022 12:28
@msanft msanft removed the request for review from datosh December 12, 2022 12:30
@msanft msanft merged commit dd4fc0d into main Dec 12, 2022
@msanft msanft deleted the feat/IAMCreationDocs branch December 12, 2022 12:33
@thomasten thomasten added the no changelog Change won't be listed in release changelog label Jan 11, 2023
@m1ghtym0 m1ghtym0 mentioned this pull request Jan 17, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datosh datosh datosh left review comments

@thomasten thomasten thomasten approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@msanft @datosh @thomasten @katexochen
0