8000 AB#2579 Add constellation iam create command by msanft · Pull Request #624 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AB#2579 Add constellation iam create command #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

AB#2579 Add constellation iam create command #624

merged 1 commit into from
Dec 7, 2022

Conversation

msanft
Copy link
Contributor
@msanft msanft commented Nov 22, 2022 •
edited
Loading

Proposed change(s)

  • Add constellation iam create command to the Constellation CLI, automatically sets up the required IAM configuration based on the paramters supplied by the user by using Terraform scripts.
  • Command output will consist of the values for the constellation-conf.yml that need to be filled in by the user.

Additional info

GCP

  • Command: constellation iam create gcp
  • You must be authenticated with the GCP CLI in the used shell context.
  • Available flags are:
  • zone: Required. GCP zone you want to create the configuration in.
  • serviceAccountID: Required. ID for the service account that will be created. Must match ^[a-z](?:[-a-z0-9]{4,28}[a-z0-9])$
  • projectID: Required. ID of the GCP project the configuration will be created in.
  • yes: Skips confirmation steps.

AWS

  • Command: constellation iam create aws
  • You must be authenticated with the AWS CLI in the used shell context.
  • Available flags are:
  • zone: Required. AWS availability zone you want to create the configuration in.
  • prefix: Required. Name prefix which will be used to create the IAM resources.
  • yes: Skips confirmation steps.

Azure

  • Command: constellation iam create azure
  • You must be authenticated with the Azure CLI in the used shell context.
  • Available flags are:
  • region: Required. Azure region you want to create the configuration in.
  • resourceGroup: Required. Name of the resource group the IAM resources will be created in.
  • servicePrincipal: Required. Name of the service principal that will be created.
  • yes: Skips confirmation steps.

Checklist

@netlify
Copy link
netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 61f3878
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6390654c6156760008ccec19
😎 Deploy Preview https://deploy-preview-624--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Nirusu
Nirusu reviewed Nov 22, 2022
View reviewed changes
katexochen
katexochen reviewed Nov 22, 2022
View reviewed changes
Copy link
Member
@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

Just some early feedback. Great code quality! 🦤

@m1ghtym0 m1ghtym0 mentioned this pull request Nov 23, 2022
Closed
2 tasks
@msanft msanft force-pushed the feat/IAMCreateCommand branch 6 times, most recently from a53712d to f704664 Compare November 24, 2022 12:25
@msanft msanft changed the title WIP: add constellation iam create gcp command WIP: AB#2579 Add constellation iam create command Nov 24, 2022
@msanft msanft force-pushed the feat/IAMCreateCommand branch from c5a7867 to 600b570 Compare November 24, 2022 12:34
@msanft msanft requested review from Nirusu and katexochen November 24, 2022 12:36
@Nirusu
Copy link
Contributor
Nirusu commented Nov 24, 2022

Can you please fix the linter warnings first before I review? :)

@msanft msanft force-pushed the feat/IAMCreateCommand branch 2 times, most recently from a4ce146 to 72188e2 Compare November 24, 2022 14:12
@Nirusu
Copy link
Contributor
Nirusu commented Nov 24, 2022

Regarding the "Check licenses" step, can you add this as the header to each of the file reported in there (= new *.go files created as part of your PR)?

/*
Copyright (c) Edgeless Systems GmbH
SPDX-License-Identifier: AGPL-3.0-only
*/

Then the check should pass.

Nirusu
Nirusu reviewed Nov 24, 2022
View reviewed changes
@msanft msanft force-pushed the feat/IAMCreateCommand branch 5 times, most recently from fea7b7d to 1487b99 Compare December 1, 2022 13:25
@msanft msanft changed the title WIP: AB#2579 Add constellation iam create command AB#2579 Add constellation iam create command Dec 1, 2022
@msanft msanft marked this pull request as ready for review December 1, 2022 13:33
@msanft msanft requested review from Nirusu and 3u13r December 2, 2022 10:27
8000
3u13r
3u13r suggested changes Dec 2, 2022
View reviewed changes
Copy link
Contributor
@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good work! Regarding change requests nothing too major.

@msanft msanft force-pushed the feat/IAMCreateCommand branch from c86a7a8 to 4a547b3 Compare December 5, 2022 08:02
@msanft msanft requested a review from 3u13r December 5, 2022 08:03
3u13r
3u13r suggested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor
@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change request from my side. Otherwise looking good.

@msanft msanft force-pushed the feat/IAMCreateCommand branch from 4a547b3 to fed133d Compare December 5, 2022 12:00
katexochen
katexochen requested changes Dec 5, 2022
View reviewed changes
@msanft msanft force-pushed the feat/IAMCreateCommand branch from fed133d to cdbfa0a Compare December 5, 2022 12:22
@msanft msanft removed the request for review from Nirusu December 5, 2022 12:23
datosh
datosh approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor
@datosh datosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to agree with @katexochen , great code quality!

@msanft msanft requested review from katexochen and 3u13r December 7, 2022 09:52
@katexochen
Copy link
Member

@stdoutput could you rebase on main?

@msanft msanft force-pushed the feat/IAMCreateCommand branch from cdbfa0a to 61f3878 Compare December 7, 2022 10:04
katexochen
katexochen approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member
@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦭

3u13r
3u13r approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor
@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msanft msanft merged commit 286803f< ABFE /code> into main Dec 7, 2022
@msanft msanft deleted the feat/IAMCreateCommand branch December 7, 2022 10:48
@m1ghtym0 m1ghtym0 mentioned this pull request Jan 17, 2023
Closed
8 tasks
david-crypto pushed a commit that referenced this pull request Oct 3, 2024
@m1ghtym0
continuum-proxy: add helm chart (#624)
5c571c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datosh datosh datosh approved these changes

@Nirusu Nirusu Nirusu left review comments

@3u13r 3u13r 3u13r approved these changes

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msanft @Nirusu @katexochen @datosh @3u13r
0