This repository was archived by the owner on Jan 15, 2020. It is now read-only.
Resolve #214 Keep validation markers for model reload #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Seems to work in most cases, but I found a bug where error markers for resolved problems are not cleared on (re)validation: Why do we need to reapply old markers before an update? Doesn't |
This commit improves the model index to correctly update the indices for incoming and outgoing edges of nodes in case edges are deleted. Beforehand, these indices were not updated.
In case of deleting edges, the model index got unnecessarily polluted due to calling the operation SModelIndex.get[Incomging|Outgoing]Edges also for edges when computing dependent elements that should be deleted together with the edges. This commit introduces a condition so that incoming and outgoing edges are only considered as dependent elements of nodes, i.e., the mentioned SModelIndex operations are only for nodes.
This commit introduces an own feedback emitter for the (re-)application of validation markers on the diagram. This feedback emitter eases the addition and removal of feedback actions for marker (re-)application. Also, the interface IFeedbackEmitter could be simplified.
This commit introduces the Clear Markes Action and corresponding command, which are responsible for clearing old markers visualized on the diagram. This can be necessary in case of a re-validation, namely when previously retrieved markers become obsolete. Also, it can be used to allow the user to clear all visualized makers.
cda36c5 to
ff8ed1f
Compare
|
@tortmayr, thanks for your review and feedback! I hope my new changes fix the problems you encountered! |
tortmayr
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.