[1244] Make LibraryPackage's isStandard checkbox read-only #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelRICHARD
reviewed
May 13, 2025
CHANGELOG.adoc
Outdated
| @@ -35,6 +35,8 @@ When end-users click on _New Object_ on a semantic element, and select a `ViewUs | |||
| - https://github.com/eclipse-syson/syson/issues/1255[#1255] [general-view] Improve label of `TransitionUsage` to display the "AcceptParameterPart". | |||
| - https://github.com/eclipse-syson/syson/issues/1210[#1210] general-view] Add the `parameters` compartment on `ActionDefinition` in the _General View_ diagram. | |||
| - https://github.com/eclipse-syson/syson/issues/1267[#1267] [general-view] Improve the New Perform tool selection dialog to display existing actions in a tree. | |||
| - https://github.com/eclipse-syson/syson/issues/1244[#1244] [details] Make LibraryPackage's `isStandard` checkbox read-only in the details view. | |||
There was a problem hiding this comment.
Make LibraryPackage's isStandard checkbox read-only in the details view. => Make LibraryPackage's isStandard checkbox read-only in the Details view.
| @@ -181,6 +181,8 @@ image::StateTransitionUsageLabels.png[TransitionUsage labels] | |||
| image::release-notes-GV-actionDefinition-parameters.png[Parameters compartment on ActionDefinition] | |||
|
|
|||
| - In the _General View_ diagram, the selection dialog to reference an existing `Action` when creating a new `Perform Action` has been improved to present those `Actions` in a hierarchical way. | |||
| - Make LibraryPackage's `isStandard` checkbox read-only in the details view. | |||
There was a problem hiding this comment.
Make LibraryPackage's isStandard checkbox read-only in the details view. => Make LibraryPackage's isStandard checkbox read-only in the details view. => Make LibraryPackage's isStandard checkbox read-only in the Details view.
Bug: #1244 Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
50846f2 to
e95fefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes LibraryPackage's
isStandardcheckbox read-only in the details view. The issue originally proposes to remove the checkbox, but I think it provide relevant information to the end user.Making it read-only let the user get the information while enforcing the fact that SysON does not support non-SysML, non-KerML standard libraries.
Note that the PR does not address the question of the textual import of a standard library package.
Fixes #1244
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests