8000 [1257] Add perform actions compartment in Parts by jerome-obeo · Pull Request #1266 · eclipse-syson/syson · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[1257] Add perform actions compartment in Parts #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

[1257] Add perform actions compartment in Parts #1266

merged 1 commit into from
May 12, 2025

Conversation

jerome-obeo
Copy link
Contributor
@jerome-obeo jerome-obeo commented Apr 30, 2025 •
edited by AxelRICHARD
Loading

Bug: #1257

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

adaussy
adaussy suggested changes May 5, 2025
View reviewed changes
Copy link
Contributor
@adaussy adaussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install the compartement on :

  • PartUsage, PartDefinition and all inherited concepts
  • ActionUsage, ActionDefinition` and all inherited concepts

...lipse/syson/diagram/general/view/nodes/PerformActionsCompartmentNodeDescriptionProvider.java Outdated
protected NodePalette createCompartmentPalette(IViewDiagramElementFinder cache) {
var palette = this.diagramBuilderHelper.newNodePalette().dropNodeTool(this.createCompartmentDropFromDiagramTool(cache));

// // Do not use getItemCreationToolProvider because the compartment contains multiple creation tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AxelRICHARD AxelRICHARD added this to the 2025.6.0 milestone May 6, 2025
@AxelRICHARD AxelRICHARD linked an issue May 6, 2025 that may be closed by this pull request
Add perform actions compartment in Parts #1257
Closed
@AxelRICHARD
Copy link
Member

Please install the compartement on :

  • PartUsage, PartDefinition and all inherited concepts
  • ActionUsage, ActionDefinition` and all inherited concepts

Please do that in separated PRs

@jerome-obeo
Copy link
Contributor Author

A new issue has been filed #1277 to track the installation of the perform actions compartment in Actions.
Therefore, this issue (and PR) will be focused on Parts.

@AxelRICHARD
Copy link
Member
AxelRICHARD commented May 7, 2025 •
edited
Loading

A new issue has been filed #1277 to track the installation of the perform actions compartment in Actions. Therefore, this issue (and PR) will be focused on Parts.

Ok thank you, please fix the build of this PR before starting a new contribution.

@jerome-obeo jerome-obeo force-pushed the jgo/enh/add_perform_action_compartment_in_parts branch 3 times, most recently from 0e63096 to 7fc758c Compare May 7, 2025 17:00
@jerome-obeo @AxelRICHARD
[1257] Add perform actions compartment in Parts
b3e3f03 
Bug: eclipse-syson#1257
Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
@AxelRICHARD AxelRICHARD force-pushed the jgo/enh/add_perform_action_compartment_in_parts branch from 7fc758c to b3e3f03 Compare May 12, 2025 13:09
@AxelRICHARD AxelRICHARD merged commit 3874ef6 into eclipse-syson:main May 12, 2025
3 checks passed
@jerome-obeo jerome-obeo deleted the jgo/enh/add_perform_action_compartment_in_parts branch May 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaussy adaussy adaussy requested changes

Assignees
No one assigned
Labels
pr: to review soon priority: high
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.

Add perform actions compartment in Parts
3 participants
@jerome-obeo @AxelRICHARD @adaussy
0