8000 Improve resolution of textKeys and iconIds by bschwarzent · Pull Request #1528 · eclipse-scout/scout.rt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve resolution of textKeys and iconIds #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up f 8000 or GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: releases/25.2
Choose a base branch
from
Open

Improve resolution of textKeys and iconIds #1528

wants to merge 1 commit into from

Conversation

bschwarzent
Copy link
Member
  • Match entire string instead of substrings (that was most likely not intentional)
  • The default namespace for iconIds is 'scout'. This now also works if the 'scout.icons' object is replaced.
  • Extract resolution to dedicated methods to allow overriding.
  • Cleanup code
  • Cleanup JsDoc
  • Add specs

411068

7F84
@bschwarzent
Improve resolution of textKeys and iconIds
59c552d 
- Match entire string instead of substrings (that was most likely not
  intentional)
- The default namespace for iconIds is 'scout'. This now also works
  if the 'scout.icons' object is replaced.
- Extract resolution to dedicated methods to allow overriding.
- Cleanup code
- Cleanup JsDoc
- Add specs

411068
@bschwarzent bschwarzent self-assigned this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bschwarzent bschwarzent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bschwarzent
0