Health Check: Remember last status per category #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[EDIT: Resolved with new commit] Thanks! Shouldn't we either have the timestamp per category in the map or invalidate the map on every put operation? Now one could query for category 1 and subsequently for a long time for category 2 and then get a stale answer for category 1. |
|
Can one of the admins verify this patch? |
paolobazzi
reviewed
May 9, 2025
| @@ -169,12 +174,21 @@ else if (m_timeout > 0 && m_futureStart + m_timeout < System.currentTimeMillis() | |||
| * @param result | |||
| * status of last executed health check | |||
| */ | |||
| protected void notifyHealthCheckResult(boolean result) { | |||
| protected void notifyHealthCheckResult(boolean result, HealthCheckCategoryId category) { | |||
There was a problem hiding this comment.
I wouldn't change the signature (API) of this method in a minor build. Move this signature change to 25/2
| } | ||
| } | ||
|
|
||
| private static final class Empty implements IHealthCheckCategory { |
There was a problem hiding this comment.
This class is not available as bean as it is marked "private static final". I think this is the intended behavior, maybe add a javadoc indicating that this is just a sentinel value and not a real category available for health checking.
db10a07 to
b710404
Compare
b710404 to
c7efe91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
419786