Fix NPE in SessionDiagnosticsObject::onShutdown
#1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the `SessionDiagnosticObject` was added to the `sessionDiagnosticsObjects` map before having `startup()` called, it was possible that during shutdown we could attempt to shut down a `SessionDiagnosticObject` that hadn't been started yet, and therefore had `null` fields. fixes #1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
SessionDiagnosticObjectwas added to thesessionDiagnosticsObjectsmap before havingstartup()called, it was possible that during shutdown we could attempt to shut down aSessionDiagnosticObjectthat hadn't been started yet, and therefore hadnullfields.fixes #1445