8000 Refactoring in Registration class by sbernard31 · Pull Request #1007 · eclipse-leshan/leshan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactoring in Registration class #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 3, 2021
Merged

Refactoring in Registration class #1007

merged 8 commits into from
Jun 3, 2021

Conversation

sbernard31
Copy link
Contributor
@sbernard31 sbernard31 commented May 5, 2021 •
edited
Loading

Some refactoring needed to prepare the support of "ct=" attribute at server Side.

Notable behavior breaks :

  • equals/hashcode
  • Version used instead of String in Registration
  • Registration is no more Serializable
  • Registration Constructor takes the builder in argument instead of a too long list of arguments.

About the last point, we have many constructors with too many constructor argument in the Leshan code base maybe we should generalized this approach ? 🤔

@sbernard31 sbernard31 force-pushed the refactoring_registration branch from b0e87ed to 7848fb8 Compare May 10, 2021 13:48
@sbernard31 sbernard31 force-pushed the refactoring_registration branch from 7848fb8 to dad83de Compare June 3, 2021 09:33
msangoi
msangoi approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor
@msangoi msangoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbernard31 sbernard31 changed the base branch from ct_for_client to master June 3, 2021 13:40
@sbernard31 sbernard31 merged commit dad83de into master Jun 3, 2021
@sbernard31 sbernard31 deleted the refactoring_registration branch June 30, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msangoi msangoi msangoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernard31 @msangoi
0