8000 NPE on RedisRegistration cleanup · Issue #1333 · eclipse-leshan/leshan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NPE on RedisRegistration cleanup #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvermillard opened this issue Oct 20, 2022 · 0 comments · Fixed by #1334
Closed

NPE on RedisRegistration cleanup #1333

jvermillard opened this issue Oct 20, 2022 · 0 comments · Fixed by #1334
Labels
enhancement Improvement of existing features Redis Impact redis component

Comments

@jvermillard
Copy link
Contributor

I seen those log appearing on a test server (leshan 2.0.0-M9)

java.lang.NullPointerException: Cannot read the array length because "bytes" is null
at java.base/java.lang.String.<init>(String.java:1435)
at org.eclipse.leshan.server.redis.serialization.RegistrationSerDes.deserialize(RegistrationSerDes.java:284)
at org.eclipse.leshan.server.redis.RedisRegistrationStore.deserializeReg(RedisRegistrationStore.java:486)
at org.eclipse.leshan.server.redis.RedisRegistrationStore.access$000(RedisRegistrationStore.java:73)
at org.eclipse.leshan.server.redis.RedisRegistrationStore$Cleaner.run(RedisRegistrationStore.java:831)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)

I'm not sure how this is possible, but I think we can make the code more defensive
@jvermillard jvermillard mentioned this issue Oct 20, 2022
Merged
@sbernard31 sbernard31 added Redis Impact redis component enhancement Improvement of existing features labels Oct 20, 2022
sbernard31 pushed a commit that referenced this issue Oct 21, 2022
@jvermillard @sbernard31
GH-1333: don't delete the expiration index, just avoid the NPE
c96ae82 
Signed-off-by: Julien Vermillard <julien@vermillard.com>
sbernard31 pushed a commit that referenced this issue Oct 21, 2022
@jvermillard @sbernard31
GH-1333: Prevent NPE in RedisStore Registration Cleaner
a314ff2 
Signed-off-by: Julien Vermillard <julien@vermillard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of existing features Redis Impact redis component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent NPE on expiration pointing to unknown registration eclipse-leshan/leshan
2 participants
@sbernard31 @jvermillard
0