8000 Better Registration Application Data Support · Issue #1293 · eclipse-leshan/leshan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Better Registration Application Data Support #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbernard31 opened this issue Jul 20, 2022 · 3 comments
Closed

Better Registration Application Data Support #1293

sbernard31 opened this issue Jul 20, 2022 · 3 comments
Labels
enhancement Improvement of existing features server Impact LWM2M server
Milestone
2.0.0

Comments

@sbernard31
Copy link
Contributor

When a register request is received, the Authorizer is responsible to decide if client registration is accepted or not.

Often this Authorizer gathers data about this client which can be necessary to attach to the registration.

We already have some kind of API to do that :

  1. Authorizer.isAuthorized() returns a Registration and so a custom Registraton can be created (but that sounds not so good because this implies to create custom RegistrationStore too to handle it.
  2. Then we add Map<String, String> getApplicationData() and so this will be automatically handled by RegistrationStore implementation. (Add a way to add application Data  #1018)

But neither 1) nor 2) supports Application Data update on Registration Update Request.

Maybe we should change the API of Authorizer to make it returns ApplicationData on success.
Then used this Application Data :

  • to create Registration on RegistrationHandler.register
  • to create RegistrationUpdate which can handle ApplicationData modification on RegistrationHandler.update.
@sbernard31 sbernard31 added server Impact LWM2M server enhancement Improvement of existing features labels Jul 20, 2022
@sbernard31 sbernard31 added this to the 2.0.0 milestone Jul 20, 2022
@sbernard31
Copy link
Contributor Author
sbernard31 commented Jul 20, 2022 •
edited
Loading

(Note : there was a bug until 3ceb009 : Application Data was lost on update. It will be fixed in 2.0.0-M8)

This was referenced Nov 23, 2022
Closed
Merged
@sbernard31
Copy link
Contributor Author
sbernard31 commented Nov 25, 2022 •
edited
Loading

I'm working on this at Done at : #1361

sbernard31 added a commit that referenced this issue Nov 30, 2022
@sbernard31
GH-1293: Enhance ApplicationData support (new Authorizer API)
7547de5
@sbernard31
Copy link
Contributor Author

Intregrated (PR #1361) in master (should be available in 2.0.0-M10)

@sbernard31 sbernard31 mentioned this issue Dec 1, 2022
Merged
@sbernard31 sbernard31 mentioned this issue Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of existing features server Impact LWM2M server
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@sbernard31
0