10000 Test actual, not declared behaviour by pzygielo · Pull Request #160 · eclipse-ee4j/orb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test actual, not declared behaviour #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

pzygielo
Copy link
Contributor
@pzygielo pzygielo commented Aug 4, 2024

No description provided.

@pzygielo pzygielo marked this pull request as ready for review August 4, 2024 11:08
@pzygielo pzygielo requested a review from a team August 4, 2024 13:23
@smillidge
Copy link
Contributor

Hi could you add some description to what the PR is fixing. It seems correct but not sure what the issue was.

@pzygielo
Copy link
Contributor Author
pzygielo commented Aug 6, 2024

Inherited methods in super process annotations on processor (like old tests).
But our processor can override those methods and return different values.
I believe we are interested in the result of method calling (as it happens in processing time), hence the change.

@pzygielo pzygielo added this to the 4.2.6 milestone Aug 12, 2024
@pzygielo pzygielo merged commit 32bfaf2 into eclipse-ee4j:master Aug 12, 2024
2 checks passed
@pzygielo pzygielo deleted the pre159 branch August 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0