8000 fixed that "condition" query param could not be provided as form field by thjaeckle · Pull Request #1848 · eclipse-ditto/ditto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixed that "condition" query param could not be provided as form field #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

thjaeckle
Copy link
Member
  • which prevented long conditions to be used via POST /search/things

* which prevented long conditions to be used via POST /search/things

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the bug label Dec 21, 2023
@thjaeckle thjaeckle added this to the 3.4.4 milestone Dec 21, 2023
@thjaeckle thjaeckle self-assigned this Dec 21, 2023
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki could you please have a look?

When #1706 was done, it was forgotten to also expose the condition as form parameter - which leads to the same problem #1706 aimed to solve: potentially too long query parameter when passing a "condition" via query-param or HTTP-header.

@thjaeckle thjaeckle merged commit be1b9c6 into master Jan 2, 2024
@thjaeckle thjaeckle deleted the bugfix/post-search-with-condition-as-form-field branch January 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant
0