8000 automatically update public/ assets on change by mattvr · Pull Request #64 · extension-js/extension.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

automatically update public/ assets on change #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2024
Merged

automatically update public/ assets on change #64

merged 1 commit into from
May 20, 2024

Conversation

mattvr
Copy link
Contributor
@mattvr mattvr commented May 19, 2024

Addresses #62

This PR updates the behavior of the public/ folder to be watched for changes and copy files over while the extension is running.

Testing

Manually tested on Firefox & Chrome with CSS & JS assets in an extension popup/action. Saw that the popup updated immediately when the files were changed without requiring a full restart.

Also ran yarn test and saw everything still passed.

Other

Updated documentation here https://github.com/cezaraugusto/extension.js.org/pull/2

Copy link
Member
@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to know it is all working! Thanks for updating the docs as well! ++

@cezaraugusto cezaraugusto merged commit 81c0890 into extension-js:main May 20, 2024
@mattvr mattvr deleted the mattvr/reload-public branch May 21, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0