8000 [expo-router] add submenus to link preview context menu by Ubax · Pull Request #37784 · expo/expo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[expo-router] add submenus to link preview context menu #37784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

[expo-router] add submenus to link preview context menu #37784

merged 1 commit into from
Jul 3, 2025
+306 −89

Conversation

Ubax
Copy link
Contributor
@Ubax Ubax commented Jul 1, 2025 •
edited
Loading

Why

link-preview-submenu-multiple-levels.mov (uploaded via Graphite)

How

  1. Using existing <Link.Menu> and <Link.MenuAction> for nested menus
  2. Passes nested menus as children
  3. When mounting children on native side they are added to subitems, which are later transformed into submenu

Test Plan

  1. Manual testin

Checklist

@Ubax Ubax mentioned this pull request Jul 1, 2025
Merged
3 tasks
@Ubax Graphite App
Copy link
Contributor Author
Ubax commented Jul 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 1, 2025
@Ubax Ubax force-pushed the ubax/router/link-preview-icon branch from fa0aa3a to b1be02b Compare July 1, 2025 18:34
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch 2 times, most recently from 5d6d5d0 to ec49a19 Compare July 1, 2025 18:34
@Ubax Ubax force-pushed the ubax/router/link-preview-icon branch from b1be02b to c258db9 Compare July 2, 2025 12:15
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch from ec49a19 to 5fe88ac Compare July 2, 2025 12:15
@Ubax Ubax mentioned this pull request Jul 2, 2025
Merged
3 tasks
@Ubax Ubax force-pushed the ubax/router/link-preview-icon branch from c258db9 to 9cc6136 Compare July 2, 2025 14:54
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch from 5fe88ac to 4d82a14 Compare July 2, 2025 14:54
@Ubax Ubax marked this pull request as ready for review July 2, 2025 14:54
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 2, 2025

Subscribed to pull request

File Patterns Mentions
packages/expo-router/** @EvanBacon, @marklawlor

Generated by CodeMention

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 2, 2025
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch from 4d82a14 to 98d765d Compare July 2, 2025 14:59
@Ubax Ubax force-pushed the ubax/router/link-preview-icon branch from 9cc6136 to 27b97b0 Compare July 2, 2025 14:59
@Ubax Ubax requested review from EvanBacon and marklawlor July 2, 2025 15:00
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch from 98d765d to cb22c01 Compare July 2, 2025 16:11
EvanBacon
EvanBacon approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor
@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Ubax Ubax force-pushed the ubax/router/link-preview-icon branch 2 times, most recently from 63c4f67 to fd1d67f Compare July 3, 2025 07:25
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch 3 times, most recently from 35a5174 to 8836e46 Compare July 3, 2025 08:37
@Ubax Ubax force-pushed the ubax/router/link-preview-icon branch from fd1d67f to 598030b Compare July 3, 2025 08:37
@Ubax Ubax changed the base branch from ubax/router/link-preview-icon to graphite-base/37784 July 3, 2025 10:22
@Ubax Ubax force-pushed the graphite-base/37784 branch from 598030b to 73446eb Compare July 3, 2025 10:22
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch from 8836e46 to 91316b9 Compare July 3, 2025 10:22
@graphite-app graphite-app bot changed the base branch from graphite-base/37784 to main July 3, 2025 10:23
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch 2 times, most recently from eaff435 to c2fe848 Compare July 3, 2025 10:50
@Ubax Ubax force-pushed the ubax/router/link-preview-submenus branch from c2fe848 to 1dfda47 Compare July 3, 2025 10:56
@Ubax Ubax merged commit c62d4a7 into main Jul 3, 2025
23 checks passed
@Ubax Ubax deleted the ubax/router/link-preview-submenus branch July 3, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon EvanBacon approved these changes

@marklawlor marklawlor Awaiting requested review from marklawlor

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ubax @EvanBacon @expo-bot
0