8000 [docs] Update Expo tutorial by amandeepmittal · Pull Request #36818 · expo/expo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[docs] Update Expo tutorial #36818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amandeepmittal
Copy link
Member

Why

Minor improvements are required in Expo tutorial for SDK 53.

Fix ENG-15530 ENG-15749

How

  • Fix TypeScript error on Animated.Image for image source type prop by using ImageSourcePropType from react-native
  • Remove +not-found route from code snippets since it is not required to explicitly define this route in the root layout file
  • Verify all code snippets from the tutorial are working by following them manually in a newly created project with SDK 53
  • Other minor improvements include correct code annotation highlights in code blocks and update one outdated screenshot for SDK 53 in which app icon is shown

Test Plan

By running docs app locally.

Checklist

Copy link
Contributor

Subscribed to pull request

File Patterns Mentions
docs/** @Simek

Generated by CodeMention

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 12, 2025
@amandeepmittal amandeepmittal changed the title [docs] Update Expo tutorail [docs] Update Expo tutorial May 12, 2025
Copy link
Collaborator
@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM! 👍

@amandeepmittal amandeepmittal merged commit b733412 into main May 13, 2025
14 of 15 checks passed
@amandeepmittal amandeepmittal deleted the aman/eng-15749-when-i-copied-the-code-an-error-occurred-the-reason-is-that branch May 13, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0