8000 [eas-json] Allow a string of 1-50 characters as a track name by algoORgoal · Pull Request #3031 · expo/eas-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[eas-json] Allow a string of 1-50 characters as a track name #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitH 8000 ub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[eas-json] Allow a string of 1-50 characters as a track name #3031

wants to merge 4 commits into from

Conversation

algoORgoal
Copy link
@algoORgoal algoORgoal commented May 25, 2025 •
edited
Loading

Why

Previously, the Android submit track in eas.json only allowed a fixed set of values ("beta", "alpha", "internal", "production"). However, Google Play supports custom track names, and users may need to specify arbitrary track names for advanced workflows. This PR enables more flexible usage by allowing any string of 1 8000 -50 characters as a track name.
Track name follows the rule defined by Google textfield. See the image below.

  1. When textfield is empty
    Empty Trackname textfield
  2. When textfield has an input within 50 characters
    Track name textfield within 50 characters
  3. When textfied has an input over 50 characters
    Track name textfield over 50 characters

How

  • Updated the Joi runtime schema in packages/eas-json/src/submit/schema.ts to allow any string of 1-50 characters for the Android submit track property.
  • Updated the JSON schema in packages/eas-json/schema/eas.schema.json to add minLength and maxLength for the track property, ensuring IDE and documentation support matches runtime validation.
  • Added and updated tests in packages/eas-json/src/__tests__/submitProfiles-test.ts to cover:
    • Valid custom track names within 50 characters
    • Invalid track names (empty string, over 50 characters)
    • Default value behavior when track is omitted

Test Plan

  • Ran the test suite to ensure all new and existing tests pass.
  • Verified that:
    • A custom track name (e.g., my-custom-track) is accepted.
    • An empty string or a string longer than 50 characters is rejected.
    • Omitting the track property defaults to internal.

If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
Test results on terminal

@github-actions GitHub Actions
< 8000 div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false">
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

@algoORgoal algoORgoal changed the title Fix/flexible track names Allow a string of 1-50 characters as a track name May 25, 2025
@algoORgoal
Copy link
Author

/changelog-entry [bug-fix] [Allow a string of 1-50 characters as a track name]

@algoORgoal algoORgoal changed the title Allow a string of 1-50 characters as a track name [eas-cli] Allow a string of 1-50 characters as a track name May 25, 2025
@algoORgoal
Copy link
Author
algoORgoal commented May 25, 2025 •
edited
Loading

@quinlanj I tried to follow the pr description to update the changelog, but it seems like it's not working. Can you help me? Thank you.

@algoORgoal algoORgoal changed the title [eas-cli] Allow a string of 1-50 characters as a track name [eas-json] Allow a string of 1-50 characters as a track name May 25, 2025
@algoORgoal
Copy link
Author

/changelog-entry bug-fix Allow a string of 1-50 characters as a track name

@algoORgoal algoORgoal mentioned this pull request May 26, 2025
Open
@kadikraman
Copy link
Contributor

Thanks for the PR. This also requires some API schema changes on our part so we'll need to tackle those first.

In the meanwhile since the actual change is quite small, you can unblock yourself by adding the change on your local project with patch-package (or yarn patch if you're using yarn, bun patch if you're using bun etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algoORgoal @kadikraman
0