{{ message }}
Fix editor scroll position #1306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, it looks like this broke the tests. |
|
@kntsoriano I think we want Turbo, not Hotwire (Hotwire also installs Stimulus, which we don't want to use at least for now). Spend a day working on replacing Turbolinks with Turbo. See whether it works or not. If it looks like it'll be too painful, we'll just abort, but if we can do it, that'd be good 🙂 |
|
@kntsoriano This would be a good one for you to look at next week while I'm away. |
|
@kntsoriano Can we close this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exercism/v3-beta#143
This is a known error for Turbolinks, and I copied the solution here: turbolinks/turbolinks#181 (comment)
It seems to me that turbolinks/turbolinks#420 is the PR for this fix, but it won't seem to get merged anytime soon. Should we look into using Hotwire now?