[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1103: editAs not working #1104

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Fix #1103: editAs not working #1104

merged 5 commits into from
Feb 10, 2020

Conversation

Alanscut
Copy link
Member
@Alanscut Alanscut commented Feb 3, 2020

@alubbe
Copy link
Member
alubbe commented Feb 6, 2020

I'm not entirely sure what this PR is about - @Siemienik do you know? @Alanscut could you elaborate a little bit and maybe provide a test case?

@Alanscut
Copy link
Member Author
Alanscut commented Feb 6, 2020

ok, I will add some test for it later.
when you add an image to a worksheet, property editAs will control how the image is anchored to the cell(s). it could be undefined, oneCell or absolute. But when you set it to absolute, the value of editAs in generated excel file will still be oneCell.
https://github.com/exceljs/exceljs/blob/master/README.md#add-image-over-a-range
pr-1104

@Alanscut
Copy link
Member Author
Alanscut commented Feb 6, 2020

there is another problem. The README says undefined is the default value of property editAs, however, the actual situation is that oneCell is the default value. In fact, when creating a Excel file and inserting an image to it, the default property of editAs is oneCell too. So should I change the readme file?

@Siemienik
Copy link
Member

AD. undefined in documentation - I think, we should update readme, and all will be ok.

@alubbe
Copy link
Member
alubbe commented Feb 8, 2020

@Alanscut yeah let's update the README and then we're good to go

@Siemienik Siemienik merged commit 9fa0c13 into exceljs:master Feb 10, 2020
@Alanscut Alanscut deleted the fix_editAs branch March 5, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants