Rename feesplit to revenue #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo0MTEyMTI0NTQ6Y29tbWl0OjU4OTViYjI2ZjZhMTIzYWUwNWFhNmRmNGNiOTZlZGI0ZTM1YmQ4NzEiLCJ0IjoxNzQ3OTMxNzgxfQ==--96bb1393861d77d22a8f25c6a95ee8804466a546e1c2780e86e4559c2750494e" data-url="/evmos/evmos/pull/929/partials/commit_status_icon?oid=5895bb26f6a123ae05aa6df4cb96edb4e35bd871">
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v8.2.x #929 +/- ##
==================================================
- Coverage 81.00% 80.99% -0.02%
==================================================
Files 127 127
Lines 7277 7278 +1
==================================================
Hits 5895 5895
- Misses 1241 1242 +1
Partials 141 141
|
|
There are some occurrences of |
danburck
previously requested changes
Sep 22, 2022
There was a problem hiding this comment.
@ramacarlucho I added some missing renames and tested the upgrade with this branch. Querying the revenue module works fine, but I noticed that the module params are not set and default to their zero values
➜ evmosd q revenue params
addr_derivation_cost_create: "0"
developer_shares: "0.000000000000000000"
enable_revenue: false
Still need to address this
fedekunze
added a commit
that referenced
this pull request
Sep 27, 2022
* release: v8.0.0 changelog & upgrade heights (#848) * deps: bump tendermint `v0.34.21` (#861) * `v8.1.0` Release (#875) * `v8.1.0` Release changelog (#877) update changelog * Upgrade handler (#880) * add v8.1 upgrade handler * update constants * update comment * fix linter * fix(app): implement hard fork logic for v8.2.0 * Revert "fix(app): implement hard fork logic for v8.2.0" This reverts commit d2e248c. * fix(app): implement hard fork logic for v8.2.0 * update block height * changelog * chore(app): v8.2.0 upgrade handler + store upgrade (#923) * chore(app): v8.2.0 upgrade handler * changelog * comment * chore: Rename `feesplit` module to `revenue` (#929) * renamed feesplit as revenue for 8.2 * update comments and docs * missing renames * fix proto query godoc * replace feeSplit with revenue * replace var fee with var revenue` * rerun make proto-gen with godoc changes * add migration for setting revenue paramters Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> * imp(app): delete unnecessary upgrade logic (#932) * delete unnecessary upgrade * delete revenue keeper * delete revenue keeper * remove feesplit module from version map * Update app/upgrades/v8_2/upgrades.go Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(app): update binary architectures for upgrades (#933) * fix(app): update binary architectures for upgrades * changelog * Update CHANGELOG.md Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> * chore(app): update upgrade height for v8.2.0 * bump imports to v9 * make proto-gen and go mod tidy Co-authored-by: Tuan Pham Anh <baabeetaa@gmail.com> Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed
feesplitmodule torevenueto avoid conflicts on the store due to incorrect upgrade.Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...