8000 [ENG-175] bump erc20 test coverage (backport #482) by mergify[bot] · Pull Request #495 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENG-175] bump erc20 test coverage (backport #482) #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[ENG-175] bump erc20 test coverage (backport #482) #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/erc20/keeper/evm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (k Keeper) CallEVMWithData(
Data: (*hexutil.Bytes)(&data),
})
if err != nil {
return nil, sdkerrors.Wrapf(sdkerrors.ErrJSONMarshal, "failled to marshal tx args: %s", err.Error())
return nil, sdkerrors.Wrapf(sdkerrors.ErrJSONMarshal, "failed to marshal tx args: %s", err.Error())
}

gasRes, err := k.evmKeeper.EstimateGas(sdk.WrapSDKContext(ctx), &evmtypes.EthCallRequest{
Expand Down
2 changes: 1 addition & 1 deletion x/erc20/keeper/evm_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func (h Hooks) PostTxProcessing(
// continue to allow transfers for the ERC20 in case the token pair is disabled
h.k.Logger(ctx).Debug(
"ERC20 token -> Cosmos coin conversion is disabled for pair",
"coin", pair.Denom, "contract", pair.Erc20Address, "error", err.Error(),
"coin", pair.Denom, "contract", pair.Erc20Address,
)
continue
}
Expand Down
287 changes: 287 additions & 0 deletions x/erc20/keeper/evm_hooks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ import (

sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/ethereum/go-ethereum/common"
ethtypes "github.com/ethereum/go-ethereum/core/types"

"github.com/tharsis/ethermint/tests"
"github.com/tharsis/evmos/v3/contracts"
"github.com/tharsis/evmos/v3/x/erc20/types"
)

Expand Down Expand Up @@ -64,8 +67,47 @@ func (suite *KeeperTestSuite) TestEvmHooksRegisterERC20() {
},
false,
},
{
"Pair is disabled",
func(contractAddr common.Address) {
pair, err := suite.app.Erc20Keeper.RegisterERC20(suite.ctx, contractAddr)
suite.Require().NoError(err)

pair.Enabled = false
suite.app.Erc20Keeper.SetTokenPair(suite.ctx, *pair)
// Mint 10 tokens to suite.address (owner)
_ = suite.MintERC20Token(contractAddr, suite.address, suite.address, big.NewInt(10))
suite.Commit()

// Burn the 10 tokens of suite.address (owner)
_ = suite.BurnERC20Token(contractAddr, suite.address, big.NewInt(10))

},
false,
},
{
"Pair is incorrectly loaded",
func(contractAddr common.Address) {
pair, err := suite.app.Erc20Keeper.RegisterERC20(suite.ctx, contractAddr)
suite.Require().NoError(err)

suite.app.Erc20Keeper.DeleteTokenPair(suite.ctx, *pair)

suite.app.Erc20Keeper.SetDenomMap(suite.ctx, pair.Denom, pair.GetID())
suite.app.Erc20Keeper.SetERC20Map(suite.ctx, pair.GetERC20Contract(), pair.GetID())
// Mint 10 tokens to suite.address (owner)
_ = suite.MintERC20Token(contractAddr, suite.address, suite.address, big.NewInt(10))
suite.Commit()

// Burn the 10 tokens of suite.address (owner)
_ = suite.BurnERC20Token(contractAddr, suite.address, big.NewInt(10))

},
false,
},
}
for _, tc := range testCases {

suite.Run(fmt.Sprintf("Case %s", tc.name), func() {
suite.mintFeeCollector = true
suite.SetupTest()
Expand Down Expand Up @@ -156,3 +198,248 @@ func (suite *KeeperTestSuite) TestEvmHooksRegisterCoin() {
}
suite.mintFeeCollector = false
}

func (suite *KeeperTestSuite) TestEvmHooksForceError() {

msg := ethtypes.NewMessage(
types.ModuleAddress,
&common.Address{},
0,
big.NewInt(0), // amount
uint64(0), // gasLimit
big.NewInt(0), // gasFeeCap
big.NewInt(0), // gasTipCap
big.NewInt(0), // gasPrice
[]byte{},
ethtypes.AccessList{}, // AccessList
true, // checkNonce
)

account := tests.GenerateAddress()

transferData := []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
transferData[31] = uint8(10)
erc20 := contracts.ERC20BurnableContract.ABI

transferEvent := erc20.Events["Transfer"]

testCases := []struct {
name string
test func()
}{
{
"correct transfer (non burn)",
func() {
contractAddr, err := suite.DeployContract("coin", "token", erc20Decimals)
suite.Require().NoError(err)
suite.Commit()

_, err = suite.app.Erc20Keeper.RegisterERC20(suite.ctx, contractAddr)
suite.Require().NoError(err)

topics := []common.Hash{transferEvent.ID, account.Hash(), account.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
Address: contractAddr,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err = suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"correct burn",
func() {
contractAddr, err := suite.DeployContract("coin", "token", erc20Decimals)
suite.Require().NoError(err)
suite.Commit()

pair, err := suite.app.Erc20Keeper.RegisterERC20(suite.ctx, contractAddr)
suite.Require().NoError(err)

topics := []common.Hash{transferEvent.ID, account.Hash(), types.ModuleAddress.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
Address: contractAddr,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err = suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
sender := sdk.AccAddress(account.Bytes())
cosmosBalance := suite.app.BankKeeper.GetBalance(suite.ctx, sender, pair.Denom)

transferEvent, err := erc20.Unpack("Transfer", transferData)
suite.Require().NoError(err)

tokens, _ := transferEvent[0].(*big.Int)
suite.Require().Equal(cosmosBalance.Amount.String(), tokens.String())

},
},
{
"Unspecified Owner",
func() {
contractAddr, err := suite.DeployContract("coin", "token", erc20Decimals)
suite.Require().NoError(err)
suite.Commit()

pair, err := suite.app.Erc20Keeper.RegisterERC20(suite.ctx, contractAddr)
suite.Require().NoError(err)

pair.ContractOwner = types.OWNER_UNSPECIFIED
suite.app.Erc20Keeper.SetTokenPair(suite.ctx, *pair)

topics := []common.Hash{transferEvent.ID, account.Hash(), types.ModuleAddress.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
Address: contractAddr,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err = suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"Fail Evm",
func() {
contractAddr, err := suite.DeployContract("coin", "token", erc20Decimals)
suite.Require().NoError(err)
suite.Commit()

pair, err := suite.app.Erc20Keeper.RegisterERC20(suite.ctx, contractAddr)
suite.Require().NoError(err)

pair.ContractOwner = types.OWNER_MODULE
suite.app.Erc20Keeper.SetTokenPair(suite.ctx, *pair)

topics := []common.Hash{transferEvent.ID, account.Hash(), types.ModuleAddress.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
Address: contractAddr,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err = suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"No log address",
func() {
topics := []common.Hash{transferEvent.ID, account.Hash(), types.ModuleAddress.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err := suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"No data on topic",
func() {
topics := []common.Hash{transferEvent.ID}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err := suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"Empty logs",
func() {
log := ethtypes.Log{}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err := suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"No log data",
func() {
topics := []common.Hash{transferEvent.ID, account.Hash(), types.ModuleAddress.Hash()}
log := ethtypes.Log{
Topics: topics,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err := suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"Non transfer event",
func() {
aprovalEvent := erc20.Events["Approval"]
topics := []common.Hash{aprovalEvent.ID, account.Hash(), account.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err := suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
{
"Non recognized event",
func() {
topics := []common.Hash{{}, account.Hash(), account.Hash()}
log := ethtypes.Log{
Topics: topics,
Data: transferData,
}
receipt := &ethtypes.Receipt{
Logs: []*ethtypes.Log{&log},
}

err := suite.app.Erc20Keeper.Hooks().PostTxProcessing(suite.ctx, msg, receipt)
suite.Require().NoError(err)
},
},
}
for _, tc := range testCases {
suite.Run(fmt.Sprintf("Case %s", tc.name), func() {
suite.mintFeeCollector = true
suite.SetupTest()
suite.ensureHooksSet()

tc.test()

})
}
suite.mintFeeCollector = false
}
Loading
0