8000 [ENG-128] Fee distribution - types tests by loredanacirstea · Pull Request #464 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENG-128] Fee distribution - types tests #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 7, 2022
Merged

[ENG-128] Fee distribution - types tests #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4e62b56
x/fees - add unit tests for params & msg
loredanacirstea Apr 6, 2022
3ebf4d3
x/fees - add genesis unit tests
loredanacirstea Apr 6, 2022
8c6159b
x/fees - add unit tests for types/fee
loredanacirstea Apr 6, 2022
f95cdbf
x/fees - 0 address unit test
loredanacirstea Apr 6, 2022
2d6e8ad
x/fees - testing setup changes (PR review)
loredanacirstea Apr 6, 2022
8ee39ee
Merge branch 'main' into loredana/ENG-128-fee-distribution-types-tests
loredanacirstea Apr 6, 2022
79deb43
Apply suggestions from code review
fedekunze Apr 7, 2022
1f091fd
x/fees tests - fix imports
loredanacirstea Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions x/fees/types/fee.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,20 @@ package types

import (
sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
"github.com/ethereum/go-ethereum/common"
ethermint "github.com/tharsis/ethermint/types"
)

// NewFee returns an instance of DevFeeInfo
func NewDevFeeInfo(
contract common.Address,
owner,
deployer,
withdraw sdk.AccAddress,
) DevFeeInfo {
return DevFeeInfo{
ContractAddress: contract.String(),
DeployerAddress: owner.String(),
DeployerAddress: deployer.String(),
WithdrawAddress: withdraw.String(),
}
}
Expand All @@ -25,12 +26,21 @@ func (i DevFeeInfo) Validate() error {
return err
}

if ethermint.IsZeroAddress(i.ContractAddress) {
return sdkerrors.Wrapf(
sdkerrors.ErrInvalidAddress, "address must not be empty %s",
i.ContractAddress,
)
}

if _, err := sdk.AccAddressFromBech32(i.DeployerAddress); err != nil {
return err
}

if _, err := sdk.AccAddressFromBech32(i.WithdrawAddress); err != nil {
return err
if i.WithdrawAddress != "" {
if _, err := sdk.AccAddressFromBech32(i.WithdrawAddress); err != nil {
return err
}
}

return nil
Expand Down
149 changes: 149 additions & 0 deletions x/fees/types/fee_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
package types

import (
"testing"

sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/ethereum/go-ethereum/common"
"github.com/stretchr/testify/suite"

"github.com/tharsis/ethermint/tests"
)

type FeeTestSuite struct {
suite.Suite
address1 sdk.AccAddress
address2 sdk.AccAddress
}

func TestFeeSuite(t *testing.T) {
suite.Run(t, new(FeeTestSuite))
}

func (suite *FeeTestSuite) SetupTest() {
suite.address1 = sdk.AccAddress(tests.GenerateAddress().Bytes())
suite.address2 = sdk.AccAddress(tests.GenerateAddress().Bytes())
}

func (suite *FeeTestSuite) TestDevFeeInfoNew() {
testCases := []struct {
name string
contract common.Address
deployer sdk.AccAddress
withdraw sdk.AccAddress
expectPass bool
}{
{
"Create fee info - pass",
tests.GenerateAddress(),
suite.address1,
suite.address2,
true,
},
{
"Create fee info, omit withdraw - pass",
tests.GenerateAddress(),
suite.address1,
nil,
true,
},
{
"Create fee info - invalid contract address",
common.Address{},
suite.address1,
suite.address2,
false,
},
{
"Create fee info - invalid deployer address",
tests.GenerateAddress(),
sdk.AccAddress{},
suite.address2,
false,
},
}

for _, tc := range testCases {
i := NewDevFeeInfo(tc.contract, tc.deployer, tc.withdraw)
err := i.Validate()

if tc.expectPass {
suite.Require().NoError(err, tc.name)
} else {
suite.Require().Error(err, tc.name)
}
}
}

func (suite *FeeTestSuite) TestFee() {
testCases := []struct {
msg string
feeInfo DevFeeInfo
expectPass bool
}{
{
"Create fee info - pass",
DevFeeInfo{
tests.GenerateAddress().String(),
suite.address1.String(),
suite.address2.String(),
},
true,
},
{
"Create fee info - invalid contract address (not hex)",
DevFeeInfo{
"0x5dCA2483280D9727c80b5518faC4556617fb19ZZ",
suite.address1.String(),
suite.address2.String(),
},
false,
},
{
"Create fee info - invalid contract address (invalid length 1)",
DevFeeInfo{
"0x5dCA2483280D9727c80b5518faC4556617fb19",
suite.address1.String(),
suite.address2.String(),
},
false,
},
{
"Create fee info - invalid contract address (invalid length 2)",
DevFeeInfo{
"0x5dCA2483280D9727c80b5518faC4556617fb194FFF",
suite.address1.String(),
suite.address2.String(),
},
false,
},
{
"Create fee info - invalid deployer address",
DevFeeInfo{
tests.GenerateAddress().String(),
"evmos14mq5c8yn9jx295ahaxye2f0xw3tlell0lt542Z",
suite.address2.String(),
},
false,
},
{
"Create fee info - invalid withdraw address",
DevFeeInfo{
tests.GenerateAddress().String(),
suite.address1.String(),
"evmos14mq5c8yn9jx295ahaxye2f0xw3tlell0lt542Z",
},
false,
},
}

for _, tc := range testCases {
err := tc.feeInfo.Validate()

if tc.expectPass {
suite.Require().NoError(err, tc.msg)
} else {
suite.Require().Error(err, tc.msg)
}
}
}
172 changes: 172 additions & 0 deletions x/fees/types/genesis_test.go
View file
Open in desktop
AE8F
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
package types

import (
"testing"

sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/stretchr/testify/suite"
"github.com/tharsis/ethermint/tests"
)

type GenesisTestSuite struct {
suite.Suite
address1 string
address2 string
}

func TestGenesisTestSuite(t *testing.T) {
suite.Run(t, new(GenesisTestSuite))
}

func (suite *GenesisTestSuite) SetupTest() {
suite.address1 = sdk.AccAddress(tests.GenerateAddress().Bytes()).String()
suite.address2 = sdk.AccAddress(tests.GenerateAddress().Bytes()).String()
}

func (suite *GenesisTestSuite) TestValidateGenesis() {
newGen := NewGenesisState(DefaultParams(), []DevFeeInfo{})
testCases := []struct {
name string
genState *GenesisState
expPass bool
}{
{
name: "valid genesis constructor",
genState: &newGen,
expPass: true,
},
{
name: "default",
genState: DefaultGenesisState(),
expPass: true,
},
{
name: "valid genesis",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{},
},
expPass: true,
},
{
name: "valid genesis - with fee information",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address1,
},
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec8",
DeployerAddress: suite.address2,
WithdrawAddress: suite.address2,
},
},
},
expPass: true,
},
{
name: "empty genesis",
genState: &GenesisState{},
expPass: false,
},
{
name: "invalid genesis - duplicated fee info",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address1,
},
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address1,
},
},
},
expPass: false,
},
{
name: "invalid genesis - duplicated fee info 2",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address1,
},
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address2,
},
},
},
expPass: false,
},
{
name: "invalid genesis - invalid contract address",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: suite.address1,
DeployerAddress: suite.address1,
},
},
},
expPass: false,
},
{
name: "invalid genesis - invalid deployer address",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
},
},
},
expPass: false,
},
{
name: "invalid genesis - invalid withdraw address",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address1,
WithdrawAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
},
},
},
expPass: false,
},
{
name: "invalid genesis - invalid params",
genState: &GenesisState{
Params: DefaultParams(),
DevFeeInfos: []DevFeeInfo{
{
ContractAddress: "0xdac17f958d2ee523a2206206994597c13d831ec7",
DeployerAddress: suite.address1,
WithdrawAddress: "withdraw",
},
},
},
expPass: false,
},
}

for _, tc := range testCases {
err := tc.genState.Validate()
if tc.expPass {
suite.Require().NoError(err, tc.name)
} else {
suite.Require().Error(err, tc.name)
}
}
}
Loading
0