8000 fix(test): Verify account balance ante fix tests by 0xstepit · Pull Request #3007 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(test): Verify account balance ante fix tests #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix(test): Verify account balance ante fix tests #3007

merged 3 commits into from
Dec 2, 2024

Conversation

0xstepit
Copy link
Contributor
@0xstepit 0xstepit commented Nov 29, 2024 •
edited
Loading

Description

Add support for custom decimals to account verification

Testing

To test fixed ante:

go test -v -tags=test ./app/ante/evm -run ^TestEvmAnteTestSuite$ -testify.m TestVerifyAccountBalance

Closes: #ENG-2689

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Nov 29, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the tests label Nov 29, 2024
@0xstepit 0xstepit changed the title add support for custom decimals + fix tests fix(test): Verify account balance ante fix tests Nov 29, 2024
@0xstepit 0xstepit marked this pull request as ready for review December 2, 2024 13:34
@0xstepit 0xstepit requested a review from a team as a code owner December 2, 2024 13:34
@0xstepit 0xstepit requested review from hanchon and GAtom22 and removed request for a team December 2, 2024 13:34 8000
@0xstepit 0xstepit merged commit 702cc7e into stepit/new-config-approach Dec 2, 2024
22 checks passed
@0xstepit 0xstepit deleted the stepit/fix-account-verification branch December 2, 2024 13:44
0xstepit added a commit that referenced this pull request Dec 17, 2024
@0xstepit @ramacarlucho @MalteHerrmann
feat(test): Add support for custom decimals to test suite. (#3006)
9ee7cb2 
* update names

* wip

* wip

* add base fee check

* add testing chain id to config

* update testing suite

* remove comment from tests

* remove configurator from cmd

* add license

* linter

* fix tagged files

* fix function signature

* fix(test): Verify account balance ante fix tests (#3007)

add support for custom decimals + fix tests

* remove test configurator

* remove constructor for network with config

* Update app/ante/evm/suite_test.go

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Signed-off-by: stepit <48993133+0xstepit@users.noreply.github.com>

* run make format

* Update testutil/integration/evmos/network/config.go

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Signed-off-by: stepit <48993133+0xstepit@users.noreply.github.com>

* remove unused deps in ante

* fix initial base fee in test suite

* fix can transfer

* fix vesting

* fix gas consume

* update gov genesis for custom dec

* fix gas wanted

* fix increment sequence

* remove unused configurator

* fix unit tests

* remove TODO associated with evmOS

* apply suggestions from review

* restore test

* add changelog entry

* fix changelog

---------

Signed-off-by: stepit <48993133+0xstepit@users.noreply.github.com>
Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: 0xstepit <0xstepit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanchon hanchon Awaiting requested review from hanchon hanchon was automatically assigned from evmos/core-engineering

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 was automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xstepit
0