evmos · 0xstepit · Dec 17, 2024 · Nov 27, 2024 · Nov 28, 2024 · Nov 28, 2024
@@ -72,6 +72,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 - (precompiles) [#2943](https://github.com/evmos/evmos/pull/2943) Add WERC-20 precompile.
 - (precompiles) [#2966](https://github.com/evmos/evmos/pull/2966) Add safety check that ERC-20 precompiles cannot receive funds.
 -
8000
 (app) [#3009](https://github.com/evmos/evmos/pull/3009) Move internal Evmos app initialization to input function.
+- (tests) [#3006](https://github.com/evmos/evmos/pull/3006) Add support for custom decimals to test suite and fix ante tests.
 
 ### Bug Fixes
 

@@ -21,6 +21,7 @@ func (suite *EvmAnteTestSuite) TestVerifyAccountBalance() {
 	keyring := testkeyring.New(2)
 	unitNetwork := network.NewUnitTestNetwork(
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
+		network.WithChainID(suite.chainID),
 	)
 	grpcHandler := grpc.NewIntegrationHandler(unitNetwork)
 	txFactory := factory.New(unitNetwork, grpcHandler)
@@ -53,10 +54,12 @@ func (suite *EvmAnteTestSuite) TestVerifyAccountBalance() {
 				suite.Require().NoError(err)
 
 				// Make tx cost greater than balance
-				balanceResp, err := grpcHandler.GetBalanceFromBank(senderKey.AccAddr, unitNetwork.GetBaseDenom())
+				balanceResp, err := grpcHandler.GetBalanceFromEVM(senderKey.AccAddr)
 				suite.Require().NoError(err)
 
-				invalidAmount := balanceResp.Balance.Amount.Add(math.NewInt(100))
+				balance, ok := math.NewIntFromString(balanceResp.Balance)
+				suite.Require().True(ok)
+				invalidAmount := balance.Add(math.NewInt(100))
 				txArgs.Amount = invalidAmount.BigInt()
 				return statedbAccount, txArgs
 			},
@@ -98,7 +101,7 @@ func (suite *EvmAnteTestSuite) TestVerifyAccountBalance() {
 	}
 
 	for _, tc := range testCases {
-		suite.Run(fmt.Sprintf("%v_%v", evmtypes.GetTxTypeName(suite.ethTxType), tc.name), func() {
+		suite.Run(fmt.Sprintf("%v_%v_%v", evmtypes.GetTxTypeName(suite.ethTxType), suite.chainID, tc.name), func() {
 			// Perform test logic
 			statedbAccount, txArgs := tc.generateAccountAndArgs()
 			txData, err := txArgs.ToTxData()

@@ -20,6 +20,7 @@ import (
 func (suite *EvmAnteTestSuite) TestCanTransfer() {
 	keyring := testkeyring.New(1)
 	unitNetwork := network.NewUnitTestNetwork(
+		network.WithChainID(suite.chainID),
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
 	)
 	grpcHandler := grpc.NewIntegrationHandler(unitNetwork)
@@ -45,9 +46,12 @@ func (suite *EvmAnteTestSuite) TestCanTransfer() {
 			expectedError: errortypes.ErrInsufficientFunds,
 			isLondon:      true,
 			malleate: func(txArgs *evmtypes.EvmTxArgs) {
-				balanceResp, err := grpcHandler.GetBalanceFromBank(senderKey.AccAddr, unitNetwork.GetBaseDenom())
+				balanceResp, err := grpcHandler.GetBalanceFromEVM(senderKey.AccAddr)
 				suite.Require().NoError(err)
-				invalidAmount := balanceResp.Balance.Amount.Add(math.NewInt(1)).BigInt()
+
+				balance, ok := math.NewIntFromString(balanceResp.Balance)
+				suite.Require().True(ok)
+				invalidAmount := balance.Add(math.NewInt(1)).BigInt()
 				txArgs.Amount = invalidAmount
 			},
 		},
@@ -61,7 +65,7 @@ func (suite *EvmAnteTestSuite) TestCanTransfer() {
 	}
 
 	for _, tc := range testCases {
-		suite.Run(fmt.Sprintf("%v_%v", evmtypes.GetTxTypeName(suite.ethTxType), tc.name), func() {
+		suite.Run(fmt.Sprintf("%v_%v_%v", evmtypes.GetTxTypeName(suite.ethTxType), suite.chainID, tc.name), func() {
 			baseFeeResp, err := grpcHandler.GetEvmBaseFee()
 			suite.Require().NoError(err)
 			ethCfg := unitNetwork.GetEVMChainConfig()

@@ -23,6 +23,7 @@ type AccountExpenses = map[string]*evm.EthVestingExpenseTracker
 func (suite *EvmAnteTestSuite) TestCheckVesting() {
 	keyring := testkeyring.New(1)
 	unitNetwork := network.NewUnitTestNetwork(
+		network.WithChainID(suite.chainID),
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
 	)
 	grpcHandler := grpc.NewIntegrationHandler(unitNetwork)

@@ -9,7 +9,6 @@ import (
 	sdktypes "github.com/cosmos/cosmos-sdk/types"
 	errortypes "github.com/cosmos/cosmos-sdk/types/errors"
 	"github.com/ethereum/go-ethereum/common"
-	anteutils "github.com/evmos/evmos/v20/app/ante/utils"
 	"github.com/evmos/evmos/v20/types"
 	evmtypes "github.com/evmos/evmos/v20/x/evm/types"
 )
@@ -35,10 +34,7 @@ func UpdateCumulativeGasWanted(
 }
 
 type ConsumeGasKeepers struct {
-	Bank         anteutils.BankKeeper
-	Distribution anteutils.DistributionKeeper
-	Evm          EVMKeeper
-	Staking      anteutils.StakingKeeper
+	Evm EVMKeeper
 }
 
 // ConsumeFeesAndEmitEvent deduces fees from sender and emits the event

@@ -3,17 +3,21 @@
 package evm_test
 
 import (
+	"fmt"
+
 	"cosmossdk.io/math"
 	sdktypes "github.com/cosmos/cosmos-sdk/types"
 	evmante "github.com/evmos/evmos/v20/app/ante/evm"
 	"github.com/evmos/evmos/v20/testutil/integration/evmos/grpc"
 	testkeyring "github.com/evmos/evmos/v20/testutil/integration/evmos/keyring"
 	"github.com/evmos/evmos/v20/testutil/integration/evmos/network"
+	evmtypes "github.com/evmos/evmos/v20/x/evm/types"
 )
 
 func (suite *EvmAnteTestSuite) TestUpdateCumulativeGasWanted() {
 	keyring := testkeyring.New(1)
 	unitNetwork := network.NewUnitTestNetwork(
+		network.WithChainID(suite.chainID),
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
 	)
 
@@ -86,29 +90,28 @@ func (suite *EvmAnteTestSuite) TestUpdateCumulativeGasWanted() {
 func (suite *EvmAnteTestSuite) TestConsumeGasAndEmitEvent() {
 	keyring := testkeyring.New(1)
 	unitNetwork := network.NewUnitTestNetwork(
+		network.WithChainID(suite.chainID),
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
 	)
 	grpcHandler := grpc.NewIntegrationHandler(unitNetwork)
 
 	testCases := []struct {
 		name          string
 		expectedError string
-		fees          sdktypes.Coins
+		feesAmt       math.Int
 		getSender     func() sdktypes.AccAddress
 	}{
 		{
-			name: "success: fees are zero and event emitted",
-			fees: sdktypes.Coins{},
+			name:    "success: fees are zero and event emitted",
+			feesAmt: math.NewInt(0),
 			getSender: func() sdktypes.AccAddress {
 				// Return prefunded sender
 				return keyring.GetKey(0).AccAddr
 			},
 		},
 		{
-			name: "success: there are non zero fees, user has sufficient bank balances and event emitted",
-			fees: sdktypes.Coins{
-				sdktypes.NewCoin(unitNetwork.GetBaseDenom(), math.NewInt(1000)),
-			},
+			name:    "success: there are non zero fees, user has sufficient bank balances and event emitted",
+			feesAmt: math.NewInt(1000),
 			getSender: func() sdktypes.AccAddress {
 				// Return prefunded sender
 				return keyring.GetKey(0).AccAddr
@@ -117,9 +120,7 @@ func (suite *EvmAnteTestSuite) TestConsumeGasAndEmitEvent() {
 		{
 			name:          "fail: insufficient user balance, event is NOT emitted",
 			expectedError: "failed to deduct transaction costs from user balance",
-			fees: sdktypes.Coins{
-				sdktypes.NewCoin(unitNetwork.GetBaseDenom(), math.NewInt(1000)),
-			},
+			feesAmt:       math.NewInt(1000),
 			getSender: func() sdktypes.AccAddress {
 				// Return unfunded account
 				index := keyring.AddKey()
@@ -129,24 +130,28 @@ func (suite *EvmAnteTestSuite) TestConsumeGasAndEmitEvent() {
 	}
 
 	for _, tc := range testCases {
-		suite.Run(tc.name, func() {
+		suite.Run(fmt.Sprintf("%v_%v_%v", evmtypes.GetTxTypeName(suite.ethTxType), suite.chainID, tc.name), func() {
 			keepers := &evmante.ConsumeGasKeepers{
-				Bank:         unitNetwork.App.BankKeeper,
-				Distribution: unitNetwork.App.DistrKeeper,
-				Evm:          unitNetwork.App.EvmKeeper,
-				Staking:      unitNetwork.App.StakingKeeper,
+				Evm: unitNetwork.App.EvmKeeper,
 			}
 			sender := tc.getSender()
-			prevBalance, err := grpcHandler.GetAllBalances(
-				sender,
-			)
+
+			resp, err := grpcHandler.GetBalanceFromEVM(sender)
 			suite.Require().NoError(err)
+			prevBalance, ok := math.NewIntFromString(resp.Balance)
+			suite.Require().True(ok)
+
+			suite.Require().NoError(err)
+
+			evmDecimals := evmtypes.GetEVMCoinDecimals()
+			feesAmt := tc.feesAmt.Mul(evmDecimals.ConversionFactor())
+			fees := sdktypes.NewCoins(sdktypes.NewCoin(unitNetwork.GetBaseDenom(), feesAmt))
 
 			// Function under test
 			err = evmante.ConsumeFeesAndEmitEvent(
 				unitNetwork.GetContext(),
 				keepers,
-				tc.fees,
+				fees,
 				sender,
 			)
 
@@ -156,31 +161,32 @@ func (suite *EvmAnteTestSuite) TestConsumeGasAndEmitEvent() {
 
 				// Check events are not present
 				events := unitNetwork.GetContext().EventManager().Events()
-				suite.Require().Zero(len(events))
+				suite.Require().Zero(len(events), "required no events to be emitted")
 			} else {
 				suite.Require().NoError(err)
 
 				// Check fees are deducted
-				afterBalance, err := grpcHandler.GetAllBalances(
-					sender,
-				)
+				resp, err := grpcHandler.GetBalanceFromEVM(sender)
 				suite.Require().NoError(err)
-				expectedBalance := prevBalance.Balances.Sub(tc.fees...)
-				suite.Require().True(
-					expectedBalance.Equal(afterBalance.Balances),
-				)
+				afterBalance, ok := math.NewIntFromString(resp.Balance)
+				suite.Require().True(ok)
+
+				suite.Require().NoError(err)
+				expectedBalance := prevBalance.Sub(feesAmt)
+				suite.Require().True(expectedBalance.Equal(afterBalance), "expected different balance after fees deduction")
 
 				// Event to be emitted
 				expectedEvent := sdktypes.NewEvent(
 					sdktypes.EventTypeTx,
-					sdktypes.NewAttribute(sdktypes.AttributeKeyFee, tc.fees.String()),
+					sdktypes.NewAttribute(sdktypes.AttributeKeyFee, fees.String()),
 				)
 				// Check events are present
 				events := unitNetwork.GetContext().EventManager().Events()
 				suite.Require().NotZero(len(events))
 				suite.Require().Contains(
 					events,
 					expectedEvent,
+					"expected different events after fees deduction",
 				)
 			}
 

@@ -14,6 +14,7 @@ import (
 func (suite *EvmAnteTestSuite) TestIncrementSequence() {
 	keyring := testkeyring.New(1)
 	unitNetwork := network.NewUnitTestNetwork(
+		network.WithChainID(suite.chainID),
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
 	)
 	grpcHandler := grpc.NewIntegrationHandler(unitNetwork)

@@ -3,26 +3,30 @@
 package evm_test
 
 import (
+	"fmt"
+
 	storetypes "cosmossdk.io/store/types"
-	errortypes "github.com/cosmos/cosmos-sdk/types/errors"
 
 	sdktypes "github.com/cosmos/cosmos-sdk/types"
+	errortypes "github.com/cosmos/cosmos-sdk/types/errors"
 	"github.com/evmos/evmos/v20/app/ante/evm"
 	"github.com/evmos/evmos/v20/testutil/integration/evmos/factory"
 	"github.com/evmos/evmos/v20/testutil/integration/evmos/grpc"
 	testkeyring "github.com/evmos/evmos/v20/testutil/integration/evmos/keyring"
 	"github.com/evmos/evmos/v20/testutil/integration/evmos/network"
 	integrationutils "github.com/evmos/evmos/v20/testutil/integration/evmos/utils"
+	evmtypes "github.com/evmos/evmos/v20/x/evm/types"
 )
 
 func (suite *EvmAnteTestSuite) TestCheckGasWanted() {
 	keyring := testkeyring.New(1)
 	unitNetwork := network.NewUnitTestNetwork(
+		network.WithChainID(suite.chainID),
 		network.WithPreFundedAccounts(keyring.GetAllAccAddrs()...),
 	)
 	grpcHandler := grpc.NewIntegrationHandler(unitNetwork)
 	txFactory := factory.New(unitNetwork, grpcHandler)
-	commonGasLimit := uint64(100000)
+	commonGasLimit := uint64(100_000)
 
 	testCases := []struct {
 		name                       string
@@ -69,16 +73,17 @@ func (suite *EvmAnteTestSuite) TestCheckGasWanted() {
 				// Set basefee param to false
 				feeMarketParams, err := grpcHandler.GetFeeMarketParams()
 				suite.Require().NoError(err)
+
 				feeMarketParams.Params.NoBaseFee = true
 				err = integrationutils.UpdateFeeMarketParams(integrationutils.UpdateParamsInput{
 					Tf:      txFactory,
 					Network: unitNetwork,
 					Pk:      keyring.GetPrivKey(0),
 					Params:  feeMarketParams.Params,
 				})
-				suite.Require().NoError(err)
+				suite.Require().NoError(err, "expected no error when updating fee market params")
 
-				blockMeter := storetypes.NewGasMeter(commonGasLimit + 10000)
+				blockMeter := storetypes.NewGasMeter(commonGasLimit + 10_000)
 				return unitNetwork.GetContext().WithBlockGasMeter(blockMeter)
 			},
 			isLondon:                   true,
@@ -87,7 +92,7 @@ func (suite *EvmAnteTestSuite) TestCheckGasWanted() {
 	}
 
 	for _, tc := range testCases {
-		suite.Run(tc.name, func() {
+		suite.Run(fmt.Sprintf("%v_%v_%v", evmtypes.GetTxTypeName(suite.ethTxType), suite.chainID, tc.name), func() {
 			sender := keyring.GetKey(0)
 			txArgs, err := txFactory.GenerateDefaultTxTypeArgs(
 				sender.Addr,

@@ -69,10 +69,7 @@ func BenchmarkEthGasConsumeDecorator(b *testing.B) {
 				cacheCtx = s.prepareAccount(cacheCtx, addr.Bytes(), tc.balance, tc.rewards)
 				s.Require().NoError(vmdb.Commit())
 				keepers := ethante.ConsumeGasKeepers{
-					Bank:         s.GetNetwork().App.BankKeeper,
-					Distribution: s.GetNetwork().App.DistrKeeper,
-					Evm:          s.GetNetwork().App.EvmKeeper,
-					Staking:      s.GetNetwork().App.StakingKeeper,
+					Evm: s.GetNetwork().App.EvmKeeper,
 				}
 
 				baseFee := s.GetNetwork().App.FeeMarketKeeper.GetParams(ctx).BaseFee

@@ -289,10 +289,7 @@ func (md MonoDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, ne
 		err = ConsumeFeesAndEmitEvent(
 			ctx,
 			&ConsumeGasKeepers{
-				Bank:         md.bankKeeper,
-				Distribution: md.distributionKeeper,
-				Evm:          md.evmKeeper,
-				Staking:      md.stakingKeeper,
+				Evm: md.evmKeeper,
 			},
 			msgFees,
 			from,

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	gethtypes "github.com/ethereum/go-ethereum/core/types"
+	"github.com/evmos/evmos/v20/utils"
 	"github.com/stretchr/testify/suite"
 )
 
@@ -15,16 +16,18 @@ type EvmAnteTestSuite struct {
 
 	// To make sure that every tests is run with all the tx types
 	ethTxType int
+	chainID   string
 }
 
 func TestEvmAnteTestSuite(t *testing.T) {
-	suite.Run(t, &EvmAnteTestSuite{
-		ethTxType: gethtypes.DynamicFeeTxType,
-	})
-	suite.Run(t, &EvmAnteTestSuite{
-		ethTxType: gethtypes.LegacyTxType,
-	})
-	suite.Run(t, &EvmAnteTestSuite{
-		ethTxType: gethtypes.AccessListTxType,
-	})
+	txTypes := []int{gethtypes.DynamicFeeTxType, gethtypes.LegacyTxType, gethtypes.AccessListTxType}
+	chainIDs := []string{utils.MainnetChainID + "-1", utils.SixDecChainID + "-1"}
+	for _, txType := range txTypes {
+		for _, chainID := range chainIDs {
+			suite.Run(t, &EvmAnteTestSuite{
+				ethTxType: txType,
+				chainID:   chainID,
+			})
+		}
+	}
 }