8000 fix(precompiles): Remove duplicate commits in precompiles by 0xstepit · Pull Request #3001 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(precompiles): Remove duplicate commits in precompiles #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix(precompiles): Remove duplicate commits in precompiles #3001

merged 2 commits into from
Nov 25, 2024

Conversation

0xstepit
Copy link
Contributor
@0xstepit 0xstepit commented Nov 25, 2024 •
edited by coderabbitai bot
Loading

Description

Remove duplicate Commit from recently added precompiles.

Summary by CodeRabbit

  • Documentation

    • Updated CHANGELOG.md to include new entries for unreleased changes, categorizing improvements, bug fixes, and significant modifications.

  • Improvements

    • Introduced new precompiles for slashing and governance.
    • Enhanced transaction handling and fee scaling.

  • Bug Fixes

    • Addressed issues with default denominations in CLI commands.
    • Removed duplicate commit call during execution of gov and slashing precompiles.

@0xstepit @ramacarlucho
remove duplicate commits in precompiles
ff039ee 
Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Nov 25, 2024 •
edited
Loading

Walkthrough

The pull request updates the CHANGELOG.md to categorize changes into "State Machine Breaking," "Improvements," and "Bug Fixes." Key modifications include replacing the EthAccount type with BaseAccount, updating the BaseFee to Decimal, and introducing a FeeMarketWrapper in the x/evm module. The Run methods in the gov and slashing precompiles have been altered to remove the state database commit operation, streamlining execution flow. Additional improvements and bug fixes are documented, reflecting structural changes aimed at enhancing functionality.

Changes

File Path Change Summary
CHANGELOG.md Updated with new entries for "State Machine Breaking," "Improvements," and "Bug Fixes"; significant changes documented.
src/types.go Removed EthAccount type; replaced with BaseAccount.
src/feemarket.go Updated BaseFee to Decimal.
src/evm.go Introduced FeeMarketWrapper for managing EVM coins with varying decimals.
src/slashing.go Modified Run method; removed state database commit operation.
src/gov.go Modified Run method; removed state database commit operation.

Possibly related PRs

Suggested reviewers

  • hanchon
  • ramacarlucho
  • GAtom22

🐇 "In the code where changes flow,
A rabbit hops, with joy to show.
With BaseAccount now in place,
And FeeMarketWrapper sets the pace.
Changelog brightens, bugs take flight,
Hopping forward, all feels right!" 🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a6bad30 and 0ad75e4.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • precompiles/gov/gov.go (0 hunks)
  • precompiles/slashing/slashing.go (0 hunks)
💤 Files with no reviewable changes (2)
  • precompiles/gov/gov.go
  • precompiles/slashing/slashing.go
🧰 Additional context used
🪛 Markdownlint (0.35.0)
CHANGELOG.md

49-49: Expected: 120; Actual: 145
Line length

(MD013, line-length)

🔇 Additional comments (1)
CHANGELOG.md (1)

49-49: Consider improving changelog entry readability

The line exceeds the recommended length of 120 characters. Consider splitting it into multiple lines for better readability:

-- (precompiles) [#3001](https://github.com/evmos/evmos/pull/3001) Remove duplicate commit call during `gov` and `slashing` precompiles execution.
++ (precompiles) [#3001](https://github.com/evmos/evmos/pull/3001) Remove duplicate commit call during
++   `gov` and `slashing` precompiles execution.

Let's verify the impact of removing duplicate commits:

🧰 Tools
🪛 Markdownlint (0.35.0)

49-49: Expected: 120; Actual: 145
Line length

(MD013, line-length)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xstepit 0xstepit marked this pull request as ready for review November 25, 2024 14:32
@0xstepit 0xstepit requested a review from a team as a code owner November 25, 2024 14:32
@0xstepit 0xstepit requested review from MalteHerrmann and GAtom22 and removed request for a team November 25, 2024 14:32
@0xstepit 0xstepit enabled auto-merge (squash) November 25, 2024 14:39
@0xstepit 0xstepit merged commit b72a32d into main Nov 25, 2024
51 of 52 checks passed
@0xstepit 0xstepit deleted the stepit/fix-commit branch November 25, 2024 15:03
@coderabbitai coderabbitai bot mentioned this pull request Nov 25, 2024
Draft
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 6, 2024
Merged
This was referenced Dec 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanchon hanchon hanchon approved these changes

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
precompile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xstepit @hanchon @ramacarlucho
0