8000 fix(evm): Update the access list with the correct precompile by 0xstepit · Pull Request #3000 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(evm): Update the access list with the correct precompile #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix(evm): Update the access list with the correct precompile #3000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9264e4
add precompile address to access list in hook
0xstepit Nov 25, 2024
9ff4740
update changelog
0xstepit Nov 25, 2024
fd1af13
move changelog to state breaking section
0xstepit Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 10000 CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
- (precompiles) [#2929](https://github.com/evmos/evmos/pull/2929) Distribution: scale balance change entries to the statedb journal to support different EVM denom precision.
- (precompiles) [#2927](https://github.com/evmos/evmos/pull/2927) Erc20: scale balance change entries to the statedb journal to support different EVM denom precision.
- (erc20) [#2962](https://github.com/evmos/evmos/pull/2962) Register ERC-20 code hash also for native ERC-20 extensions.
- (evm) [#3000](https://github.com/evmos/evmos/pull/3000) Move population of access list with precompile addresses into EVM hook.

### Improvements

Expand Down
4 changes: 4 additions & 0 deletions x/evm/keeper/precompiles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,13 @@ func (k *Keeper) GetPrecompilesCallHook(ctx sdktypes.Context) types.CallHook {
return err
}

// If the precompile instance is created, we have to update the EVM with
// only the recipient precompile and add it's address to the access list.
if found {
evm.WithPrecompiles(precompiles.Map, precompiles.Addresses)
evm.StateDB.AddAddressToAccessList(recipient)
}

return nil
}
}
5 changes: 4 additions & 1 deletion x/evm/keeper/state_transition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,10 @@ func (k *Keeper) ApplyMessageWithConfig(
// access list preparation is moved from ante handler to here, because it's needed when `ApplyMessage` is called
// under contexts where ante handlers are not run, for example `eth_call` and `eth_estimateGas`.
if rules := cfg.ChainConfig.Rules(big.NewInt(ctx.BlockHeight()), cfg.ChainConfig.MergeNetsplitBlock != nil); rules.IsBerlin {
stateDB.PrepareAccessList(msg.From(), msg.To(), evm.ActivePrecompiles(rules), msg.AccessList())
// The access list is prepared without any precompile because it is
// filled with only the recipient precompile address in the EVM'hook
// call.
stateDB.PrepareAccessList(msg.From(), msg.To(), []common.Address{}, msg.AccessList())
}

if contractCreation {
Expand Down
Loading
0