evmos · Vvaradinov · Nov 13, 2024 · Oct 15, 2024 · Oct 15, 2024 · Oct 15, 2024
@@ -30,6 +30,7 @@ jobs:
           PROTOBUF_CONFIG_FILE: .protolint.yml
           VALIDATE_NATURAL_LANGUAGE: false
           VALIDATE_OPENAPI: false
+          VALIDATE_JAVASCRIPT_STANDARD: false
           VALIDATE_JSCPD: false
           VALIDATE_GO: false
           VALIDATE_GO_MODULES: false
@@ -64,7 +64,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
 - (evm) [#2936](https://github.com/evmos/evmos/pull/2936) Add query for EVM config.
 - (app) [#2937](https://github.com/evmos/evmos/pull/2937) Fix conversion on the `CheckTxFee` ante handler and allow zero coins refunds.
 - (deps) [#2967](https://github.com/evmos/evmos/pull/2967) Bump CometBFT to `v0.38.15`.
-- (precompiles) [#2966](https://github.com/evmos/evmos/pull/2966) Add safety check that ERC20 precompiles cannot receive funds.
+- (precompiles) [#2943](https://github.com/evmos/evmos/pull/2943) Add WERC-20 precompile.
+- (precompiles) [#2966](https://github.com/evmos/evmos/pull/2966) Add safety check that ERC-20 precompiles cannot receive funds.
 
 ### Bug Fixes
 

@@ -1,7 +1,17 @@
 /** @type import('hardhat/config').HardhatUserConfig */
 module.exports = {
-  solidity: '0.8.20',
+  solidity: {
+    compilers: [
+      {
+        version: "0.8.20",
+      },
+      // This version is required to compile the werc9 contract.
+      {
+        version: "0.4.22",
+      },
+    ],
+  },
   paths: {
-    sources: './solidity'
-  }
-}
+    sources: "./solidity",
+  },
+};
@@ -13,6 +13,7 @@ import (
 
 	storetypes "cosmossdk.io/store/types"
 	bankkeeper "github.com/cosmos/cosmos-sdk/x/bank/keeper"
+	"github.com/ethereum/go-ethereum/accounts/abi"
 	"github.com/ethereum/go-ethereum/common"
 	cmn "github.com/evmos/evmos/v20/precompiles/common"
 	erc20keeper "github.com/evmos/evmos/v20/x/erc20/keeper"
@@ -143,6 +144,6 @@ func (p Precompile) Run(evm *vm.EVM, contract *vm.Contract, readOnly bool) (bz [
 
 // IsTransaction checks if the given method name corresponds to a transaction or query.
 // It returns false since all bank methods are queries.
-func (Precompile) IsTransaction(_ string) bool {
+func (Precompile) IsTransaction(_ *abi.Method) bool {
 	return false
 }
@@ -74,7 +74,7 @@ func (p Precompile) RunSetup(
 	evm *vm.EVM,
 	contract *vm.Contract,
 	readOnly bool,
-	isTransaction func(name string) bool,
+	isTransaction func(name *abi.Method) bool,
 ) (ctx sdk.Context, stateDB *statedb.StateDB, s snapshot, method *abi.Method, gasConfig storetypes.Gas, args []interface{}, err error) { //nolint:revive
 	stateDB, ok := evm.StateDB.(*statedb.StateDB)
 	if !ok {
@@ -125,7 +125,7 @@ func (p Precompile) RunSetup(
 	}
 
 	// return error if trying to write to state during a read-only call
-	if readOnly && isTransaction(method.Name) {
+	if readOnly && isTransaction(method) {
 		return sdk.Context{}, nil, s, nil, uint64(0), nil, vm.ErrWriteProtection
 	}
 

@@ -10,6 +10,7 @@ import (
 	storetypes "cosmossdk.io/store/types"
 	authzkeeper "github.com/cosmos/cosmos-sdk/x/authz/keeper"
 	distributionkeeper "github.com/cosmos/cosmos-sdk/x/distribution/keeper"
+	"github.com/ethereum/go-ethereum/accounts/abi"
 	"github.com/ethereum/go-ethereum/common"
 	cmn "github.com/evmos/evmos/v20/precompiles/common"
 	"github.com/evmos/evmos/v20/x/evm/core/vm"
@@ -76,7 +77,7 @@ func (p Precompile) RequiredGas(input []byte) uint64 {
 		return 0
 	}
 
-	return p.Precompile.RequiredGas(input, p.IsTransaction(method.Name))
+	return p.Precompile.RequiredGas(input, p.IsTransaction(method))
 }
 
 // Run executes the precompiled contract distribution methods defined in the ABI.
@@ -146,8 +147,8 @@ func (p Precompile) Run(evm *vm.EVM, contract *vm.Contract, readOnly bool) (bz [
 //   - SetWithdrawAddress
 //   - WithdrawDelegatorRewards
 //   - WithdrawValidatorCommission
-func (Precompile) IsTransaction(methodName string) bool {
-	switch methodName {
+func (Precompile) IsTransaction(method *abi.Method) bool {
+	switch method.Name {
 	case ClaimRewardsMethod,
 		SetWithdrawAddressMethod,
 		WithdrawDelegatorRewardsMethod,

@@ -7,6 +7,7 @@ import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/x/distribution/types"
 
+	"github.com/ethereum/go-ethereum/accounts/abi"
 	"github.com/ethereum/go-ethereum/common"
 	gethtypes "github.com/ethereum/go-ethereum/core/types"
 	"github.com/evmos/evmos/v20/app"
@@ -18,44 +19,44 @@ import (
 func (s *PrecompileTestSuite) TestIsTransaction() {
 	testCases := []struct {
 		name   string
-		method string
+		method abi.Method
 		isTx   bool
 	}{
 		{
 			distribution.SetWithdrawAddressMethod,
-			s.precompile.Methods[distribution.SetWithdrawAddressMethod].Name,
+			s.precompile.Methods[distribution.SetWithdrawAddressMethod],
 			true,
 		},
 		{
 			distribution.WithdrawDelegatorRewardsMethod,
-			s.precompile.Methods[distribution.WithdrawDelegatorRewardsMethod].Name,
+			s.precompile.Methods[distribution.WithdrawDelegatorRewardsMethod],
 			true,
 		},
 		{
 			distribution.WithdrawValidatorCommissionMethod,
-			s.precompile.Methods[distribution.WithdrawValidatorCommissionMethod].Name,
+			s.precompile.Methods[distribution.WithdrawValidatorCommissionMethod],
 			true,
 		},
 		{
 			distribution.FundCommunityPoolMethod,
-			s.precompile.Methods[distribution.FundCommunityPoolMethod].Name,
+			s.precompile.Methods[distribution.FundCommunityPoolMethod],
 			true,
 		},
 		{
 			distribution.ValidatorDistributionInfoMethod,
-			s.precompile.Methods[distribution.ValidatorDistributionInfoMethod].Name,
+			s.precompile.Methods[distribution.ValidatorDistributionInfoMethod],
 			false,
 		},
 		{
 			"invalid",
-			"invalid",
+			abi.Method{},
 			false,
 		},
 	}
 
 	for _, tc := range testCases {
 		s.Run(tc.name, func() {
-			s.Require().Equal(s.precompile.IsTransaction(tc.method), tc.isTx)
+			s.Require().Equal(s.precompile.IsTransaction(&tc.method), tc.isTx)
 		})
 	}
 }

@@ -48,8 +48,9 @@ var _ vm.PrecompiledContract = &Precompile{}
 type Precompile struct {
 	cmn.Precompile
 	tokenPair      erc20types.TokenPair
-	bankKeeper     bankkeeper.Keeper
 	transferKeeper transferkeeper.Keeper
+	// BankKeeper is a public field so that the werc20 precompile can use it.
+	BankKeeper bankkeeper.Keeper
 }
 
 // NewPrecompile creates a new ERC-20 Precompile instance as a
@@ -74,7 +75,7 @@ func NewPrecompile(
 			TransientKVGasConfig: storetypes.GasConfig{},
 		},
 		tokenPair:      tokenPair,
-		bankKeeper:     bankKeeper,
+		BankKeeper:     bankKeeper,
 		transferKeeper: transferKeeper,
 	}
 	// Address defines the address of the ERC-20 precompile contract.
@@ -164,8 +165,8 @@ func (p Precompile) Run(evm *vm.EVM, contract *vm.Contract, readOnly bool) (bz [
 }
 
 // IsTransaction checks if the given method name corresponds to a transaction or query.
-func (Precompile) IsTransaction(methodName string) bool {
-	switch methodName {
+func (Precompile) IsTransaction(method *abi.Method) bool {
+	switch method.Name {
 	case TransferMethod,
 		TransferFromMethod,
 		auth.ApproveMethod,