8000 feat(gov): Add VoteWeighted transaction, unit and integration tests. (backport #2922) by mergify[bot] · Pull Request #2940 · evmos/evmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(gov): Add VoteWeighted transaction, unit and integration tests. (backport #2922) #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2024
Merged

feat(gov): Add VoteWeighted transaction, unit and integration tests. (backport #2922) #2940

merged 4 commits into from
Oct 14, 2024

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Oct 14, 2024

Description

This adds the VoteWeighted transaction from the governance module to the governance precompile. Unit and integration tests are included.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

Summary by CodeRabbit

  • New Features

    • Introduced weighted voting functionality, allowing voters to express preferences with associated weights.
    • Added a new event VoteWeighted and method voteWeighted for enhanced governance voting capabilities.

  • Improvements

    • Updated governance precompile to handle weighted votes and improved transaction processing.
    • Enhanced error handling for invalid weighted voting options.
    • Performance improvements for transaction handling and gas estimation.

  • Bug Fixes

    • Fixed CLI to use the default denomination when executing the root command.

  • Tests

    • Added comprehensive tests for the new weighted voting functionality to ensure correct behavior and error handling.
This is an automatic backport of pull request #2922 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 14, 2024 13:05
@mergify mergify bot requested review from ramacarlucho and MalteHerrmann and removed request for a team October 14, 2024 13:05
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
9 tasks
@GAtom22 GAtom22 merged commit ef492af into rama/release-v20 Oct 14, 2024
19 of 22 checks passed
@GAtom22 GAtom22 deleted the mergify/bp/rama/release-v20/pr-2922 branch October 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GAtom22 GAtom22 GAtom22 approved these changes

@ramacarlucho ramacarlucho Awaiting requested review from ramacarlucho ramacarlucho is a code owner automatically assigned from evmos/core-engineering

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
precompile tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GAtom22 @Vvaradinov
0